Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 248983002: Speed up headers by using a map instead of string switching. (Closed)

Created:
6 years, 8 months ago by Anders Johnsen
Modified:
6 years, 8 months ago
CC:
reviews_dartlang.org, srdjan
Visibility:
Public.

Description

Speed up headers by using a map instead of string switching. BUG= R=lrn@google.com, sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=35305

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -86 lines) Patch
M sdk/lib/io/http_headers.dart View 1 chunk +100 lines, -86 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Anders Johnsen
srdjan@: Note that a const-map is notably slower for this - I suspect it's just ...
6 years, 8 months ago (2014-04-23 07:04:22 UTC) #1
Anders Johnsen
6 years, 8 months ago (2014-04-23 07:04:31 UTC) #2
Søren Gjesse
lgtm
6 years, 8 months ago (2014-04-23 07:16:35 UTC) #3
Lasse Reichstein Nielsen
lgtm
6 years, 8 months ago (2014-04-23 07:19:31 UTC) #4
Anders Johnsen
6 years, 8 months ago (2014-04-23 07:25:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r35305 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698