Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 248473004: Redo "JS templates" (Closed)

Created:
6 years, 8 months ago by sra1
Modified:
6 years, 8 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Redo "JS templates" Improve Primitives.objectTypeName The slightly different layout of the functions (they are now parsed and pretty-printed) confused a heuristic for getting a plausible type name from an arbitrary JS object's constructor function. Fix is to improve the heuristic. TBR=floitsch@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=35301

Patch Set 1 #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1959 lines, -1145 lines) Patch
M sdk/lib/_internal/compiler/implementation/js/builder.dart View 17 chunks +351 lines, -305 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js/js.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js/nodes.dart View 4 chunks +49 lines, -95 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js/printer.dart View 2 chunks +20 lines, -7 lines 0 comments Download
A sdk/lib/_internal/compiler/implementation/js/template.dart View 1 chunk +676 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart View 5 chunks +14 lines, -18 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart View 4 chunks +8 lines, -11 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart View 7 chunks +48 lines, -30 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart View 13 chunks +309 lines, -338 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart View 13 chunks +35 lines, -31 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/interceptor_emitter.dart View 1 11 chunks +80 lines, -120 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/metadata_emitter.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/nsm_emitter.dart View 4 chunks +117 lines, -102 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart View 3 chunks +2 lines, -9 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/native_handler.dart View 4 chunks +14 lines, -7 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 14 chunks +29 lines, -17 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/codegen.dart View 5 chunks +26 lines, -28 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/nodes.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/ssa_tracer.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/lib/isolate_helper.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/lib/js_helper.dart View 1 4 chunks +13 lines, -10 lines 0 comments Download
M sdk/lib/_internal/lib/js_mirrors.dart View 1 chunk +7 lines, -2 lines 0 comments Download
A tests/compiler/dart2js/js_parser_statements_test.dart View 1 chunk +145 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sra1
Committed patchset #2 manually as r35301 (presubmit successful).
6 years, 8 months ago (2014-04-23 04:44:52 UTC) #1
floitsch
6 years, 8 months ago (2014-04-23 07:35:35 UTC) #2
Message was sent while issue was closed. 
LGTM.

Powered by Google App Engine
This is Rietveld 408576698