Issue 248463004: Revert "Add a non-dart:io WebSocket implementation to http_parser."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 248463004: Revert "Add a non-dart:io WebSocket implementation to http_parser." (Closed)

Created:
6 years, 8 months ago by sra1

Modified:
6 years, 8 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Revert "Add a non-dart:io WebSocket implementation to http_parser." Revert "Fix an analyzer error in http_parser's WebSocket implementation." TBR=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=35297

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -1252 lines)			Patch
D	pkg/http_parser/CHANGELOG.md	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	pkg/http_parser/lib/http_parser.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	pkg/http_parser/lib/src/bytes_builder.dart	View	1 chunk	+0 lines, -214 lines	0 comments	Download
D	pkg/http_parser/lib/src/web_socket.dart	View	1 chunk	+0 lines, -936 lines	0 comments	Download
M	pkg/http_parser/pubspec.yaml	View	1 chunk	+1 line, -2 lines	0 comments	Download
D	pkg/http_parser/test/web_socket_test.dart	View	1 chunk	+0 lines, -95 lines	0 comments	Download

Total messages: 2 (0 generated)

sra1

Committed patchset #1 manually as r35297 (presubmit successful).

6 years, 8 months ago (2014-04-23 03:39:37 UTC) #1

Message was sent while issue was closed.

lgtm