Issue 24844002: Initial GUI for VM service

Issue 24844002: Initial GUI for VM service (Closed)

Created:
7 years, 2 months ago by Cutch

Modified:
7 years, 2 months ago

Reviewers:
siva, Jennifer Messerly

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Initial GUI for VM service R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=28462

Patch Set 9 : #

Total comments: 2

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1304 lines, -24 lines)			Patch
M	runtime/bin/bin.gypi	View	1 2 3 4 5 6 7	3 chunks	+6 lines, -1 line	0 comments	Download
M	runtime/bin/main.cc	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/resources_sources.gypi	View	1 2 3 4 5	2 chunks	+257 lines, -0 lines	2 comments	Download
A	runtime/bin/vmservice/client/.gitignore	View	1 2 3 4 5	1 chunk	+2 lines, -0 lines	0 comments	Download
A	runtime/bin/vmservice/client/index.html	View	1 2 3 4 5	1 chunk	+168 lines, -0 lines	0 comments	Download
A	runtime/bin/vmservice/client/index.html_bootstrap.dart	View	1 2 3 4 5	1 chunk	+34 lines, -0 lines	0 comments	Download
A	runtime/bin/vmservice/client/packages/observatory/observatory.dart	View	1 2 3 4 5	1 chunk	+13 lines, -0 lines	0 comments	Download
A	runtime/bin/vmservice/client/packages/observatory/observatory_elements.dart	View	1 2 3	1 chunk	+14 lines, -0 lines	0 comments	Download
A	runtime/bin/vmservice/client/packages/observatory/observatory_elements.html	View	1 2 3 4 5	1 chunk	+18 lines, -0 lines	0 comments	Download
A	runtime/bin/vmservice/client/packages/observatory/src/observatory/application.dart	View	1 2 3	1 chunk	+35 lines, -0 lines	0 comments	Download
A	runtime/bin/vmservice/client/packages/observatory/src/observatory/isolate_manager.dart	View	1 2 3	1 chunk	+51 lines, -0 lines	0 comments	Download
A	runtime/bin/vmservice/client/packages/observatory/src/observatory/location_manager.dart	View	1 2 3 4 5	1 chunk	+123 lines, -0 lines	0 comments	Download
A	runtime/bin/vmservice/client/packages/observatory/src/observatory/request_manager.dart	View	1 2 3 4 5	1 chunk	+64 lines, -0 lines	0 comments	Download
A	runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/collapsible_content.dart	View	1 2 3 4 5	1 chunk	+46 lines, -0 lines	0 comments	Download
A	runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/collapsible_content.html	View	1 2 3 4 5	1 chunk	+17 lines, -0 lines	0 comments	Download
A +	runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/error_view.dart	View	1 2 3 4 5 6 7	1 chunk	+6 lines, -4 lines	0 comments	Download
A	runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/error_view.html	View	1 2 3 4 5	1 chunk	+13 lines, -0 lines	0 comments	Download
A +	runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/isolate_list.dart	View	1 2 3 4 5 6 7	1 chunk	+5 lines, -4 lines	0 comments	Download
A	runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/isolate_list.html	View	1 2 3 4 5	1 chunk	+16 lines, -0 lines	0 comments	Download
A	runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/isolate_summary.dart	View	1 2 3 4 5	1 chunk	+14 lines, -0 lines	0 comments	Download
A	runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/isolate_summary.html	View	1 2 3 4 5	1 chunk	+22 lines, -0 lines	0 comments	Download
A	runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/json_view.dart	View	1 2 3 4 5	1 chunk	+56 lines, -0 lines	0 comments	Download
A	runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/json_view.html	View	1 2 3 4 5	1 chunk	+33 lines, -0 lines	0 comments	Download
A	runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/message_viewer.dart	View	1 2 3 4 5	1 chunk	+34 lines, -0 lines	0 comments	Download
A	runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/message_viewer.html	View	1 2 3 4 5	1 chunk	+28 lines, -0 lines	0 comments	Download
A	runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/navigation_bar.html	View	1 2 3 4 5	1 chunk	+19 lines, -0 lines	0 comments	Download
A	runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/observatory_application.dart	View	1 2 3 4 5	1 chunk	+20 lines, -0 lines	0 comments	Download
A	runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/observatory_application.html	View	1 2 3 4 5	1 chunk	+12 lines, -0 lines	0 comments	Download
A	runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/observatory_element.dart	View	1 2 3 4 5	1 chunk	+17 lines, -0 lines	0 comments	Download
A	runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/observatory_element.html	View	1 2 3 4 5	1 chunk	+3 lines, -0 lines	0 comments	Download
A	runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/response_viewer.html	View	1 2 3 4 5	1 chunk	+17 lines, -0 lines	0 comments	Download
A +	runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/stack_trace.dart	View	1 2 3 4 5 6 7	1 chunk	+4 lines, -3 lines	0 comments	Download
A	runtime/bin/vmservice/client/packages/observatory/src/observatory_elements/stack_trace.html	View	1 2 3 4 5	1 chunk	+27 lines, -0 lines	0 comments	Download
A	runtime/bin/vmservice/gen_resources_sources.sh	View	1 2 3 4 5	1 chunk	+49 lines, -0 lines	0 comments	Download
M	runtime/bin/vmservice/resources.dart	View	2 3	2 chunks	+3 lines, -2 lines	0 comments	Download
M	runtime/bin/vmservice/server.dart	View	2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/bin/vmservice_impl.cc	View	2 3	2 chunks	+4 lines, -1 line	0 comments	Download
M	runtime/tools/create_resources.py	View	1 2 3 4 5 6 7	5 chunks	+51 lines, -7 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Cutch

Tip for reviewing: Ignore everything in runtime/bin/vmservice/client - this has been reviewed and lgtm'd by ...

7 years, 2 months ago (2013-09-26 21:49:11 UTC) #1

siva

The non vmservice/client directory stuff LGTM. s discussed offline would be nice if we did ...

7 years, 2 months ago (2013-09-30 20:48:20 UTC) #2

Cutch

Siva, PTAL at create_resources.py changes which is fed by bin.gypi and runtime/bin/resources_sources.gypi as input.

7 years, 2 months ago (2013-09-30 22:47:43 UTC) #3

Cutch

Committed patchset #7 manually as r28422 (presubmit successful).

7 years, 2 months ago (2013-10-09 21:57:53 UTC) #5

Cutch

Committed patchset #9 manually as r28462 (presubmit successful).

7 years, 2 months ago (2013-10-10 16:36:26 UTC) #6

Jennifer Messerly

drive by comments https://codereview.chromium.org/24844002/diff/341001/runtime/bin/resources_sources.gypi File runtime/bin/resources_sources.gypi (right): https://codereview.chromium.org/24844002/diff/341001/runtime/bin/resources_sources.gypi#newcode61 runtime/bin/resources_sources.gypi:61: # Package sources Is this file ...

7 years, 2 months ago (2013-10-14 20:54:08 UTC) #7

Cutch

7 years, 2 months ago (2013-10-14 21:11:05 UTC) #8

Message was sent while issue was closed.

https://codereview.chromium.org/24844002/diff/341001/runtime/bin/resources_so...
File runtime/bin/resources_sources.gypi (right):

https://codereview.chromium.org/24844002/diff/341001/runtime/bin/resources_so...
runtime/bin/resources_sources.gypi:61: #  Package sources
Hi,

There is a script in runtime/bin/vmservice which can regenerate
resources_sources.gypi on demand. I need to hook the script up to the build
system so that it is run automatically.

John

Expand Messages | Collapse Messages