Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2484163002: Fix bug in equalsIgnoreAsciiCase. (Closed)

Created:
4 years, 1 month ago by Lasse Reichstein Nielsen
Modified:
4 years, 1 month ago
Reviewers:
nweiz, floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 14

Patch Set 2 : Address comments, add missing import. #

Total comments: 4

Patch Set 3 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -3 lines) Patch
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/comparators.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/src/equality.dart View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M pubspec.yaml View 2 1 chunk +1 line, -1 line 0 comments Download
A test/ignore_ascii_case_test.dart View 1 1 chunk +58 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
Lasse Reichstein Nielsen
4 years, 1 month ago (2016-11-08 09:38:48 UTC) #2
Lasse Reichstein Nielsen
4 years, 1 month ago (2016-11-09 12:32:26 UTC) #4
floitsch
LGTM. Was there a bug for this?
4 years, 1 month ago (2016-11-10 16:33:25 UTC) #5
nweiz
How are you envisioning this interacting with https://github.com/dart-lang/collection/pull/37? We should probably release an 0.12.1 that ...
4 years, 1 month ago (2016-11-10 21:44:44 UTC) #6
Lasse Reichstein Nielsen
@floitsch The bug was reported in https://github.com/dart-lang/collection/pull/37 I see no reason to release this first ...
4 years, 1 month ago (2016-11-11 07:56:51 UTC) #7
Lasse Reichstein Nielsen
On 2016/11/11 07:56:51, Lasse Reichstein Nielsen wrote: > @floitsch The bug was reported in > ...
4 years, 1 month ago (2016-11-11 07:57:59 UTC) #8
Lasse Reichstein Nielsen
PTAL
4 years, 1 month ago (2016-11-11 08:03:06 UTC) #9
nweiz
lgtm https://codereview.chromium.org/2484163002/diff/20001/lib/src/equality.dart File lib/src/equality.dart (right): https://codereview.chromium.org/2484163002/diff/20001/lib/src/equality.dart#newcode6 lib/src/equality.dart:6: import "comparators.dart"; Nit: newline above. https://codereview.chromium.org/2484163002/diff/20001/pubspec.yaml File pubspec.yaml ...
4 years, 1 month ago (2016-11-11 23:16:46 UTC) #10
Lasse Reichstein Nielsen
Committed patchset #3 (id:40001) manually as 47c521419576bb10b99e4412f621d51945aa1af0 (presubmit successful).
4 years, 1 month ago (2016-11-14 10:27:16 UTC) #12
Lasse Reichstein Nielsen
4 years, 1 month ago (2016-11-14 14:52:04 UTC) #13
Message was sent while issue was closed.
https://codereview.chromium.org/2484163002/diff/20001/lib/src/equality.dart
File lib/src/equality.dart (right):

https://codereview.chromium.org/2484163002/diff/20001/lib/src/equality.dart#n...
lib/src/equality.dart:6: import "comparators.dart";
On 2016/11/11 23:16:46, nweiz wrote:
> Nit: newline above.

Done.

https://codereview.chromium.org/2484163002/diff/20001/pubspec.yaml
File pubspec.yaml (right):

https://codereview.chromium.org/2484163002/diff/20001/pubspec.yaml#newcode2
pubspec.yaml:2: version: 1.12.1-dev
Super, done!

Powered by Google App Engine
This is Rietveld 408576698