Expose functionality to create a stack trace to internal vm code.

Expose functionality to create a stack trace to internal vm code.
Provide functionality to limit depth of printed stack trace.
Fix frame numbering in presence of invisible functions in stack trace.
Let FlowGraphBuilder know if it is building a graph to generate optimized code.
The above features will be used to warn on Javascript incompatibilities.

R=srdjan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=35319

[srdjan, 2014-04-23 15:53:11]

lgtm

https://codereview.chromium.org/248213002/diff/1/runtime/vm/exceptions.cc
File runtime/vm/exceptions.cc (right):

https://codereview.chromium.org/248213002/diff/1/runtime/vm/exceptions.cc#new...
runtime/vm/exceptions.cc:348: RawStacktrace* Exceptions::CurrentStacktrace() {
Maybe move this into the class Stacktrace

https://codereview.chromium.org/248213002/diff/1/runtime/vm/flow_graph_builder.h
File runtime/vm/flow_graph_builder.h (right):

https://codereview.chromium.org/248213002/diff/1/runtime/vm/flow_graph_builde...
runtime/vm/flow_graph_builder.h:248: // The graph is being rebuilt for the
optimizing compiler.
Add a comment: Do not generate different code based on this flag.

[regis, 2014-04-23 17:27:29]

Thanks!

https://codereview.chromium.org/248213002/diff/1/runtime/vm/exceptions.cc
File runtime/vm/exceptions.cc (right):

https://codereview.chromium.org/248213002/diff/1/runtime/vm/exceptions.cc#new...
runtime/vm/exceptions.cc:348: RawStacktrace* Exceptions::CurrentStacktrace() {
On 2014/04/23 15:53:12, srdjan wrote:
> Maybe move this into the class Stacktrace

Unfortunately, this would require moving lots of helper classes out of
exceptions.cc as well.

https://codereview.chromium.org/248213002/diff/1/runtime/vm/flow_graph_builder.h
File runtime/vm/flow_graph_builder.h (right):

https://codereview.chromium.org/248213002/diff/1/runtime/vm/flow_graph_builde...
runtime/vm/flow_graph_builder.h:248: // The graph is being rebuilt for the
optimizing compiler.
On 2014/04/23 15:53:12, srdjan wrote:
> Add a comment: Do not generate different code based on this flag.

Done.
I suppose you mean "different graph".

[regis, 2014-04-23 17:58:17]

Committed patchset #3 manually as r35319 (presubmit successful).