Issue 247973004: pkg/docgen: fix type warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 247973004: pkg/docgen: fix type warnings (Closed)

Created:
6 years, 8 months ago by kevmoo

Modified:
6 years, 8 months ago

Reviewers:
Alan Knight, Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

pkg/docgen: fix type warnings BUG= https://code.google.com/p/dart/issues/detail?id=18232 R=alanknight@google.com Committed: https://code.google.com/p/dart/source/detail?r=35286

Patch Set 1 #

Total comments: 1

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -11 lines)			Patch
M	pkg/docgen/lib/src/models/indexable.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/docgen/lib/src/models/model_helpers.dart	View	1 chunk	+0 lines, -1 line	1 comment	Download
M	pkg/pkg.status	View	1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kevmoo

https://codereview.chromium.org/247973004/diff/1/pkg/docgen/lib/src/models/model_helpers.dart File pkg/docgen/lib/src/models/model_helpers.dart (left): https://codereview.chromium.org/247973004/diff/1/pkg/docgen/lib/src/models/model_helpers.dart#oldcode95 pkg/docgen/lib/src/models/model_helpers.dart:95: // Issue(12202) - A declaration is public even if ...

6 years, 8 months ago (2014-04-22 22:12:58 UTC) #1

kevmoo

6 years, 8 months ago (2014-04-22 22:52:44 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r35286 (presubmit successful).

Expand Messages | Collapse Messages