Issue 247813004: Fix barback test failures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 247813004: Fix barback test failures. (Closed)

Created:
6 years, 8 months ago by nweiz

Modified:
6 years, 8 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix barback test failures. The timing changes caused by allowing transformers to return non-Futures tickled a race condition in the tests for running declaring transformers eagerly. This avoids that race condition by ensuring that the transformers are fully declared before any assets are requested. R=rnystrom@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=35283

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	pkg/barback/test/package_graph/declaring_transformer_test.dart	View		2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

6 years, 8 months ago (2014-04-22 20:45:02 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r35283 (presubmit successful).

Expand Messages | Collapse Messages