Issue 247793004: RingBuffer<T, N> utility with unit test; use for GC history.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 247793004: RingBuffer<T, N> utility with unit test; use for GC history. (Closed)

Created:
6 years, 8 months ago by koda

Modified:
6 years, 8 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

RingBuffer<T, N> utility with unit test; use for GC history. Prompted by index-out-of-bounds error in old code (bug 18375). BUG=dart:18375 R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=35384

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+86 lines, -28 lines)			Patch
M	runtime/vm/pages.h	View		3 chunks	+7 lines, -4 lines	0 comments	Download
M	runtime/vm/pages.cc	View		1 chunk	+9 lines, -24 lines	0 comments	Download
A	runtime/vm/ring_buffer.h	View	1 2	1 chunk	+41 lines, -0 lines	0 comments	Download
A	runtime/vm/ring_buffer_test.cc	View		1 chunk	+27 lines, -0 lines	0 comments	Download
M	runtime/vm/vm_sources.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTMwC -ip https://codereview.chromium.org/247793004/diff/20001/runtime/vm/ring_buffer.h File runtime/vm/ring_buffer.h (right): https://codereview.chromium.org/247793004/diff/20001/runtime/vm/ring_buffer.h#newcode18 runtime/vm/ring_buffer.h:18: COMPILE_ASSERT((N & (N - 1)) == 0, ...

6 years, 8 months ago (2014-04-24 16:45:21 UTC) #2

koda

https://codereview.chromium.org/247793004/diff/20001/runtime/vm/ring_buffer.h File runtime/vm/ring_buffer.h (right): https://codereview.chromium.org/247793004/diff/20001/runtime/vm/ring_buffer.h#newcode18 runtime/vm/ring_buffer.h:18: COMPILE_ASSERT((N & (N - 1)) == 0, N_must_be_power_of_two); On ...

6 years, 8 months ago (2014-04-24 17:07:40 UTC) #3

koda

6 years, 8 months ago (2014-04-24 17:07:55 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r35384 (presubmit successful).

Expand Messages | Collapse Messages