Issue 24775002: Fix --gc_at_alloc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24775002: Fix --gc_at_alloc (Closed)

Created:
7 years, 2 months ago by Cutch

Modified:
7 years, 2 months ago

Reviewers:
siva, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix --gc_at_alloc BUG=13619 R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=27964

Patch Set 1 #

Total comments: 1

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	runtime/vm/raw_object.cc	View		1 chunk	+3 lines, -0 lines	1 comment	Download
	M	runtime/vm/scavenger.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Cutch

Committed patchset #1 manually as r27964 (presubmit successful).

7 years, 2 months ago (2013-09-26 17:18:16 UTC) #3

Ivan Posva

7 years, 2 months ago (2013-09-27 00:28:58 UTC) #4

Message was sent while issue was closed.

DBC -ip

https://codereview.chromium.org/24775002/diff/1/runtime/vm/raw_object.cc
File runtime/vm/raw_object.cc (right):

https://codereview.chromium.org/24775002/diff/1/runtime/vm/raw_object.cc#newc...
runtime/vm/raw_object.cc:254: case kNullCid:
How come we are visiting the Null object suddenly?

Expand Messages | Collapse Messages