Move the container tracer to the call graph inferrer.

Move the container tracer to the call graph inferrer.

R=kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27992

[kasperl, 2013-09-27 05:35:43]

LGTM.

https://codereview.chromium.org/24772002/diff/3001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/inferrer/container_tracer.dart
(right):

https://codereview.chromium.org/24772002/diff/3001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/inferrer/container_tracer.dart:141:
bool disableLengthTracking = false;
Consider making this positive instead: enableLengthTracking.

https://codereview.chromium.org/24772002/diff/3001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/inferrer/container_tracer.dart:156:
List<TypeInformation> workQueue = <TypeInformation>[];
I'd rename this to worklist because you're not using it as a queue -- it is a
stack.

https://codereview.chromium.org/24772002/diff/3001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/inferrer/container_tracer.dart:235:
int positionalLength = info.arguments.positional.length;
Would it be terrible to always grab hold of the number of positionals outside
the selector.isCall test so you don't have to test for add and insert twice?

https://codereview.chromium.org/24772002/diff/3001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/inferrer/type_graph_inferrer.dart
(right):

https://codereview.chromium.org/24772002/diff/3001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/inferrer/type_graph_inferrer.dart:253:
// Set teh element type now for const lists, so that the inferrer
teh -> the

https://codereview.chromium.org/24772002/diff/3001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/inferrer/type_graph_nodes.dart
(right):

https://codereview.chromium.org/24772002/diff/3001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/inferrer/type_graph_nodes.dart:542:
String toString() => 'Call site $call receiver ${receiver.type} $type';
receiver -> on?

[ngeoffray, 2013-09-27 07:47:21]

Thanks Kasper.

https://codereview.chromium.org/24772002/diff/3001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/inferrer/container_tracer.dart
(right):

https://codereview.chromium.org/24772002/diff/3001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/inferrer/container_tracer.dart:141:
bool disableLengthTracking = false;
On 2013/09/27 05:35:43, kasperl wrote:
> Consider making this positive instead: enableLengthTracking.

Done.

https://codereview.chromium.org/24772002/diff/3001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/inferrer/container_tracer.dart:156:
List<TypeInformation> workQueue = <TypeInformation>[];
On 2013/09/27 05:35:43, kasperl wrote:
> I'd rename this to worklist because you're not using it as a queue -- it is a
> stack.

Done.

https://codereview.chromium.org/24772002/diff/3001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/inferrer/container_tracer.dart:235:
int positionalLength = info.arguments.positional.length;
On 2013/09/27 05:35:43, kasperl wrote:
> Would it be terrible to always grab hold of the number of positionals outside
> the selector.isCall test so you don't have to test for add and insert twice?

Done.

https://codereview.chromium.org/24772002/diff/3001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/inferrer/type_graph_inferrer.dart
(right):

https://codereview.chromium.org/24772002/diff/3001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/inferrer/type_graph_inferrer.dart:253:
// Set teh element type now for const lists, so that the inferrer
On 2013/09/27 05:35:43, kasperl wrote:
> teh -> the

Done.

https://codereview.chromium.org/24772002/diff/3001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/inferrer/type_graph_nodes.dart
(right):

https://codereview.chromium.org/24772002/diff/3001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/inferrer/type_graph_nodes.dart:542:
String toString() => 'Call site $call receiver ${receiver.type} $type';
On 2013/09/27 05:35:43, kasperl wrote:
> receiver -> on?

Done.

[ngeoffray, 2013-09-27 08:21:50]

Committed patchset #2 manually as r27992 (presubmit successful).