Issue 247713006: Object size on heap map hover.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 247713006: Object size on heap map hover. (Closed)

Created:
6 years, 8 months ago by koda

Modified:
6 years, 8 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Object size on heap map hover. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=35324

Patch Set 2 : #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -9 lines)			Patch
	M	runtime/bin/vmservice/client/lib/src/elements/heap_map.dart	View		2 chunks	+28 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Cutch

lgtm https://codereview.chromium.org/247713006/diff/1/runtime/vm/heap.cc File runtime/vm/heap.cc (right): https://codereview.chromium.org/247713006/diff/1/runtime/vm/heap.cc#newcode564 runtime/vm/heap.cc:564: OS::PrintErr("%s\n", js.ToCString()); remove debug code

6 years, 8 months ago (2014-04-23 19:35:59 UTC) #2

koda

6 years, 8 months ago (2014-04-23 19:41:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r35324 (presubmit successful).

Expand Messages | Collapse Messages

Issue 247713006: Object size on heap map hover. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages