Issue 247623007: Remove VM isolate new-space allocation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 247623007: Remove VM isolate new-space allocation. (Closed)

Created:
6 years, 8 months ago by koda

Modified:
6 years, 8 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Remove VM isolate new-space allocation. This was wrong, since those objects were never pre-marked. Also, in a future change, we can completely avoid reserving new-space for the VM isolate. Add ASSERT that VM isolate never allocates in new space. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=35339

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -7 lines)			Patch
M	runtime/vm/dart.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/scavenger.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/symbols.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

koda

6 years, 8 months ago (2014-04-23 22:48:36 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r35339 (presubmit successful).

Expand Messages | Collapse Messages