Issue 247473002: Expand slow marker to linux/mac for pub/test/serve/web_socket/url_to_asset_id_test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 247473002: Expand slow marker to linux/mac for pub/test/serve/web_socket/url_to_asset_id_test (Closed)

Created:
6 years, 8 months ago by ricow1

Modified:
6 years, 8 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Expand slow marker to linux/mac for pub/test/serve/web_socket/url_to_asset_id_test Committed: https://code.google.com/p/dart/source/detail?r=35259

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	sdk/lib/_internal/pub/pub.status	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ricow1

Committed patchset #1 manually as r35259 (presubmit successful).

6 years, 8 months ago (2014-04-22 14:06:57 UTC) #3

Bob Nystrom

6 years, 8 months ago (2014-04-22 16:23:50 UTC) #4

Message was sent while issue was closed.

LGTM, but do you have any idea why this test is getting slower? None of the
underlying code has changed recently, and this test should be one of the quicker
ones.

Expand Messages | Collapse Messages