Issue 24745003: Implement invoking methods with optional arguments.

Issue 24745003: Implement invoking methods with optional arguments. (Closed)

Created:
7 years, 2 months ago by ahe

Modified:
7 years, 2 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org, zarah, kasperl, rmacnak

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Implement InstanceMirror.invoke of methods with optional arguments. BUG=http://dartbug.com/6490 R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=27947

Patch Set 2 : Address comments #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -9 lines)			Patch
M	dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart	View	1	4 chunks	+16 lines, -4 lines	0 comments	Download
M	dart/tests/lib/lib.status	View		1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/lib/mirrors/invoke_named_test.dart	View		4 chunks	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM! https://codereview.chromium.org/24745003/diff/1/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart File dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right): https://codereview.chromium.org/24745003/diff/1/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart#newcode1149 dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:1149: if (signature.optionalParametersAreNamed) { This should only be for ...

7 years, 2 months ago (2013-09-26 12:32:04 UTC) #2

ahe

Thank you, Nicolas! https://codereview.chromium.org/24745003/diff/1/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart File dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right): https://codereview.chromium.org/24745003/diff/1/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart#newcode1149 dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:1149: if (signature.optionalParametersAreNamed) { On 2013/09/26 12:32:04, ...

7 years, 2 months ago (2013-09-26 12:43:21 UTC) #3

ahe

7 years, 2 months ago (2013-09-26 12:45:27 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r27947 (presubmit successful).

Expand Messages | Collapse Messages