Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 24740002: Fix https_bad_certificate_test: allow for session cache to be hit in all getUrl calls (Closed)

Created:
7 years, 2 months ago by Bill Hesse
Modified:
7 years, 2 months ago
Reviewers:
Søren Gjesse, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix https_bad_certificate_test: allow for session cache to be hit in all getUrl calls BUG= R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=27940

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tests/standalone/io/https_bad_certificate_client.dart View 1 chunk +2 lines, -2 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
Bill Hesse
The order that the getUrl calls are made in does not imply the order the ...
7 years, 2 months ago (2013-09-26 10:42:06 UTC) #1
kasperl
LGTM. https://codereview.chromium.org/24740002/diff/1/tests/standalone/io/https_bad_certificate_client.dart File tests/standalone/io/https_bad_certificate_client.dart (right): https://codereview.chromium.org/24740002/diff/1/tests/standalone/io/https_bad_certificate_client.dart#newcode52 tests/standalone/io/https_bad_certificate_client.dart:52: expect(result == 'true'); Should this have a "The ...
7 years, 2 months ago (2013-09-26 10:52:56 UTC) #2
Bill Hesse
Committed patchset #1 manually as r27940 (presubmit successful).
7 years, 2 months ago (2013-09-26 11:14:49 UTC) #3
Søren Gjesse
lgtm
7 years, 2 months ago (2013-09-26 11:19:46 UTC) #4
Bill Hesse
7 years, 2 months ago (2013-09-26 11:31:36 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/24740002/diff/1/tests/standalone/io/https_bad...
File tests/standalone/io/https_bad_certificate_client.dart (right):

https://codereview.chromium.org/24740002/diff/1/tests/standalone/io/https_bad...
tests/standalone/io/https_bad_certificate_client.dart:52: expect(result ==
'true');
On 2013/09/26 10:52:56, kasperl wrote:
> Should this have a "The session cache may keep the session." comment too?

No, this one succeeds always, and its success is what may go into the session
cache for the others to find.

Powered by Google App Engine
This is Rietveld 408576698