Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 24736002: Handle hiding dart:core imports specially. (Closed)

Created:
7 years, 2 months ago by Johnni Winther
Modified:
7 years, 2 months ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Handle hiding dart:core imports specially. BUG=http://dartbug.com/13542 R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=27938

Patch Set 1 #

Patch Set 2 : Remove unused variables. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -8 lines) Patch
M pkg/pkg.status View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/modelx.dart View 1 2 chunks +14 lines, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/warnings.dart View 2 chunks +22 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Johnni Winther
7 years, 2 months ago (2013-09-26 10:12:30 UTC) #1
kasperl
On 2013/09/26 10:12:30, Johnni Winther wrote: Is it possible to test this?
7 years, 2 months ago (2013-09-26 10:15:29 UTC) #2
Johnni Winther
On 2013/09/26 10:15:29, kasperl wrote: > On 2013/09/26 10:12:30, Johnni Winther wrote: > > Is ...
7 years, 2 months ago (2013-09-26 10:24:51 UTC) #3
kasperl
On 2013/09/26 10:24:51, Johnni Winther wrote: > On 2013/09/26 10:15:29, kasperl wrote: > > On ...
7 years, 2 months ago (2013-09-26 10:26:09 UTC) #4
ngeoffray
LGTM! Thanks Johnni.
7 years, 2 months ago (2013-09-26 10:38:12 UTC) #5
Johnni Winther
7 years, 2 months ago (2013-09-26 11:00:30 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r27938 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698