Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 247313006: Add a non-dart:io WebSocket implementation to http_parser. (Closed)

Created:
6 years, 8 months ago by nweiz
Modified:
6 years, 8 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add a non-dart:io WebSocket implementation to http_parser. R=kevmoo@google.com Committed: https://code.google.com/p/dart/source/detail?r=35287

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+308 lines, -236 lines) Patch
A pkg/http_parser/CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/http_parser/lib/http_parser.dart View 1 chunk +1 line, -0 lines 0 comments Download
A + pkg/http_parser/lib/src/bytes_builder.dart View 1 chunk +9 lines, -1 line 0 comments Download
A + pkg/http_parser/lib/src/web_socket.dart View 19 chunks +197 lines, -234 lines 0 comments Download
M pkg/http_parser/pubspec.yaml View 1 chunk +2 lines, -1 line 0 comments Download
A pkg/http_parser/test/web_socket_test.dart View 1 chunk +95 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
6 years, 8 months ago (2014-04-22 19:43:57 UTC) #1
kevmoo
lgtm
6 years, 8 months ago (2014-04-22 22:37:43 UTC) #2
nweiz
6 years, 8 months ago (2014-04-22 23:40:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r35287 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698