Fix for 14221/ 15553/ 16673- X isSubtypeOf E now returns false when X is some type and E is a type …

Fix for 14221/ 15553/ 16673- X isSubtypeOf E now returns false when X is some type and E is a type parameter.  This fixes a few issues, but also breaks some assertions (language tests that now have valid warnings from the analyzer).

Additional work will need to be done to fix the language tests, and to investigate the case of X isSubtypeOf E where X is of type Type.

R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=35281

[Brian Wilkerson, 2014-04-22 19:36:17]

LGTM

https://codereview.chromium.org/247313004/diff/40001/editor/tools/plugins/com...
File
editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticTypeWarningCodeTest.java
(right):

https://codereview.chromium.org/247313004/diff/40001/editor/tools/plugins/com...
editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticTypeWarningCodeTest.java:275:
"class B<T> {",
Do the lines above this line contribute to this test? If not, we should remove
them.

[jwren, 2014-04-22 20:03:55]

https://codereview.chromium.org/247313004/diff/40001/editor/tools/plugins/com...
File
editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticTypeWarningCodeTest.java
(right):

https://codereview.chromium.org/247313004/diff/40001/editor/tools/plugins/com...
editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticTypeWarningCodeTest.java:275:
"class B<T> {",
On 2014/04/22 19:36:17, Brian Wilkerson wrote:
> Do the lines above this line contribute to this test? If not, we should remove
> them.

Done.

[jwren, 2014-04-22 20:08:12]

Committed patchset #4 manually as r35281 (presubmit successful).