Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Issue 247273003: Fix mac gyp generation by moving target to seperate file. (Closed)

Created:
6 years, 8 months ago by ricow1
Modified:
6 years, 8 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix mac gyp generation by moving target to seperate file. R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=35256

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -27 lines) Patch
M pkg/pkg.gyp View 1 chunk +0 lines, -26 lines 0 comments Download
A pkg/pkg_files.gyp View 1 chunk +34 lines, -0 lines 0 comments Download
M utils/pub/pub.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
ricow1
6 years, 8 months ago (2014-04-22 12:58:50 UTC) #1
Bill Hesse
lgtm
6 years, 8 months ago (2014-04-22 13:01:11 UTC) #2
ricow1
6 years, 8 months ago (2014-04-22 13:01:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r35256 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698