Issue 247143009: Don't make assumptions about source encoding in analysis server tests (TBR).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 247143009: Don't make assumptions about source encoding in analysis server tests (TBR). (Closed)

Created:
6 years, 8 months ago by Paul Berry

Modified:
6 years, 8 months ago

Reviewers:
danrubel, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Don't make assumptions about source encoding in analysis server tests (TBR). On Windows, the encoding of an absolute path like "/foo.dart" contains a drive letter (e.g. "102file:///e:/foo.dart"); on Mac and Linux it doesn't. Call ".encoding" from the test so that we don't depend on the specific file name encoding in use. As a side benefit, this makes the test independent of bug 18379. Committed: https://code.google.com/p/dart/source/detail?r=35327

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	pkg/analysis_server/test/analysis_server_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Paul Berry

Committed patchset #1 manually as r35327 (presubmit successful).

6 years, 8 months ago (2014-04-23 20:02:23 UTC) #2

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages