Issue 247083002: Avoid comparing smi to mint in smi.toString().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 247083002: Avoid comparing smi to mint in smi.toString(). (Closed)

Created:
6 years, 8 months ago by Lasse Reichstein Nielsen

Modified:
6 years, 8 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Avoid comparing smi to mint in smi.toString(). As it happens 10^10 has 11 digits, not 10. R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=35249

Patch Set 2 : Add comments. #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -20 lines)			Patch
	M	runtime/lib/integers.dart	View	1	4 chunks	+17 lines, -20 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

LGTM https://codereview.chromium.org/247083002/diff/1/runtime/lib/integers.dart File runtime/lib/integers.dart (right): https://codereview.chromium.org/247083002/diff/1/runtime/lib/integers.dart#newcode317 runtime/lib/integers.dart:317: if (smi < 100) return 11; Add comment ...

6 years, 8 months ago (2014-04-22 09:21:47 UTC) #2

Lasse Reichstein Nielsen

6 years, 8 months ago (2014-04-22 09:26:43 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r35249 (presubmit successful).

Expand Messages | Collapse Messages

Issue 247083002: Avoid comparing smi to mint in smi.toString(). (Closed)

Description

Patch Set 1 #

Patch Set 2 : Add comments. #

Messages