Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 247073003: Create targets for dart2js files, pub files, pkg files. (Closed)

Created:
6 years, 8 months ago by ricow1
Modified:
6 years, 8 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Create targets for dart2js files, pub files, pkg files. We are seeing issues on mac 10.7 where the list of inputPaths in xcode files becomes to long (this is also dependent depth of your build directory). The build silently fails without giving any error. BUG:18333 Also see: http://build.chromium.org/p/client.dart/builders/dart2js-safari-mac10.7-1-3-be/builds/4640/steps/Build%20SDK/logs/stdio R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=35255

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -5 lines) Patch
M pkg/pkg.gyp View 1 2 chunks +27 lines, -1 line 2 comments Download
M utils/compiler/compiler.gyp View 1 2 3 chunks +28 lines, -1 line 1 comment Download
M utils/pub/pub.gyp View 1 2 2 chunks +33 lines, -3 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
ricow1
https://codereview.chromium.org/247073003/diff/50001/pkg/pkg.gyp File pkg/pkg.gyp (right): https://codereview.chromium.org/247073003/diff/50001/pkg/pkg.gyp#newcode47 pkg/pkg.gyp:47: '<!@(["python", "../tools/list_files.py", "", "."])', I did _not_ make this ...
6 years, 8 months ago (2014-04-22 11:03:19 UTC) #1
ahe
lgtm https://codereview.chromium.org/247073003/diff/70001/utils/pub/pub.gyp File utils/pub/pub.gyp (right): https://codereview.chromium.org/247073003/diff/70001/utils/pub/pub.gyp#newcode25 utils/pub/pub.gyp:25: '<(SHARED_INTERMEDIATE_DIR)/pgk_files.stamp', pgk -> pkg.
6 years, 8 months ago (2014-04-22 11:28:46 UTC) #2
ricow1
https://codereview.chromium.org/247073003/diff/70001/pkg/pkg.gyp File pkg/pkg.gyp (right): https://codereview.chromium.org/247073003/diff/70001/pkg/pkg.gyp#newcode52 pkg/pkg.gyp:52: '<(SHARED_INTERMEDIATE_DIR)/pgk_files.stamp', and here :-) thanks
6 years, 8 months ago (2014-04-22 11:33:29 UTC) #3
ricow1
Committed patchset #5 manually as r35255 (presubmit successful).
6 years, 8 months ago (2014-04-22 11:34:23 UTC) #4
Bill Hesse
LGTM. https://codereview.chromium.org/247073003/diff/70001/pkg/pkg.gyp File pkg/pkg.gyp (right): https://codereview.chromium.org/247073003/diff/70001/pkg/pkg.gyp#newcode35 pkg/pkg.gyp:35: # Other targets depend on pkg files, but ...
6 years, 8 months ago (2014-04-22 12:47:03 UTC) #5
Bob Nystrom
6 years, 8 months ago (2014-04-22 18:25:59 UTC) #6
Message was sent while issue was closed.
LGTM.

https://codereview.chromium.org/247073003/diff/50001/pkg/pkg.gyp
File pkg/pkg.gyp (right):

https://codereview.chromium.org/247073003/diff/50001/pkg/pkg.gyp#newcode47
pkg/pkg.gyp:47: '<!@(["python", "../tools/list_files.py", "", "."])',
On 2014/04/22 11:03:19, ricow1 wrote:
> I did _not_ make this only report dart files, since I don't know if pub will
use
> some none dart stuff

I'm not sure what you mean by "pub" here, but it's definitely valid for packages
to have non-Dart files that are relevant to their behavior. See, for example,
pkg/polymer/lib/src/js/...

Powered by Google App Engine
This is Rietveld 408576698