Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 247053004: New analyzer snapshot. (Closed)

Created:
6 years, 8 months ago by scheglov
Modified:
6 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+811 lines, -256 lines) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/ConstructorElementImpl.java View 2 chunks +2 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/ExecutableElementImpl.java View 2 chunks +2 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/FunctionElementImpl.java View 3 chunks +14 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/LibraryElementImpl.java View 3 chunks +1 line, -5 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/MethodElementImpl.java View 2 chunks +2 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/PropertyAccessorElementImpl.java View 2 chunks +2 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/VariableElementImpl.java View 2 chunks +2 lines, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/ast.dart View 2 chunks +14 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element.dart View 39 chunks +134 lines, -49 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 49 chunks +230 lines, -94 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/index.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 4 chunks +55 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 31 chunks +107 lines, -63 lines 0 comments Download
M pkg/analyzer/lib/src/generated/sdk.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source_io.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 chunk +1 line, -1 line 2 comments Download
M pkg/analyzer/test/generated/ast_test.dart View 4 chunks +26 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/element_test.dart View 20 chunks +43 lines, -24 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 3 chunks +92 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 8 chunks +66 lines, -7 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
6 years, 8 months ago (2014-04-22 16:47:25 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/247053004/diff/1/pkg/analyzer/pubspec.yaml File pkg/analyzer/pubspec.yaml (right): https://codereview.chromium.org/247053004/diff/1/pkg/analyzer/pubspec.yaml#newcode2 pkg/analyzer/pubspec.yaml:2: version: 0.13.7 With the renames, this is a ...
6 years, 8 months ago (2014-04-22 16:58:16 UTC) #2
scheglov
https://codereview.chromium.org/247053004/diff/1/pkg/analyzer/pubspec.yaml File pkg/analyzer/pubspec.yaml (right): https://codereview.chromium.org/247053004/diff/1/pkg/analyzer/pubspec.yaml#newcode2 pkg/analyzer/pubspec.yaml:2: version: 0.13.7 On 2014/04/22 16:58:16, Brian Wilkerson wrote: > ...
6 years, 8 months ago (2014-04-22 17:06:11 UTC) #3
scheglov
6 years, 8 months ago (2014-04-22 17:11:47 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 manually as r35270 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698