Issue 24703003: Fix a problem revealed by mirror_printer_test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24703003: Fix a problem revealed by mirror_printer_test. (Closed)

Created:
7 years, 2 months ago by ahe

Modified:
7 years, 2 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org, ngeoffray

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix a problem revealed by mirror_printer_test. Also update analyzer status file. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=27937

Patch Set 2 : Address comments #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -2 lines)			Patch
	M	dart/sdk/lib/_internal/lib/js_mirrors.dart	View	1	4 chunks	+12 lines, -2 lines	0 comments	Download
	M	dart/tests/lib/lib.status	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://codereview.chromium.org/24703003/diff/1/dart/sdk/lib/_internal/lib/js_mirrors.dart File dart/sdk/lib/_internal/lib/js_mirrors.dart (right): https://codereview.chromium.org/24703003/diff/1/dart/sdk/lib/_internal/lib/js_mirrors.dart#newcode1012 dart/sdk/lib/_internal/lib/js_mirrors.dart:1012: if (key == '' || Would it make ...

7 years, 2 months ago (2013-09-26 10:29:56 UTC) #2

ahe

Thank you, Kasper! https://codereview.chromium.org/24703003/diff/1/dart/sdk/lib/_internal/lib/js_mirrors.dart File dart/sdk/lib/_internal/lib/js_mirrors.dart (right): https://codereview.chromium.org/24703003/diff/1/dart/sdk/lib/_internal/lib/js_mirrors.dart#newcode1012 dart/sdk/lib/_internal/lib/js_mirrors.dart:1012: if (key == '' || On ...

7 years, 2 months ago (2013-09-26 10:38:17 UTC) #3

ahe

7 years, 2 months ago (2013-09-26 10:38:43 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r27937 (presubmit successful).

Expand Messages | Collapse Messages

Issue 24703003: Fix a problem revealed by mirror_printer_test. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comments #

Messages