Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1187)

Issue 247003008: Fix an analyzer error in http_parser's WebSocket implementation. (Closed)

Created:
6 years, 8 months ago by nweiz
Modified:
6 years, 8 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix an analyzer error in http_parser's WebSocket implementation. R=kevmoo@google.com Committed: https://code.google.com/p/dart/source/detail?r=35288

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/http_parser/lib/src/web_socket.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
6 years, 8 months ago (2014-04-22 23:52:24 UTC) #1
kevmoo
LGTM There are reasons to use the editor :-)
6 years, 8 months ago (2014-04-23 00:00:27 UTC) #2
nweiz
6 years, 8 months ago (2014-04-23 00:02:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r35288 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698