Add defer-layout tool.

Add defer-layout tool.

This is a simple tool to tell you how libraries map to output units. Here is an
example output of the tool:

  Output unit main:
    loaded by default
    contains:
       - hello_world.dart
       - dart:core
       - dart:_internal
       - dart:_js_primitives
       - dart:_js_helper
       - dart:collection
       - dart:_interceptors
       - dart:_isolate_helper
       - dart:async
       - dart:_js_names
       - dart:_foreign_helper
       - dart:_js_embedded_names
       - dart:isolate
       - dart:_async_await_error_codes

  Output unit 2:
    loaded by importing: [a, b]
    contains:
       - c.dart

  Output unit 1:
    loaded by importing: [a]
    contains:
       - a.dart

  Output unit 3:
    loaded by importing: [b]
    contains:
       - b.dart

BUG=
R=het@google.com

Committed: https://github.com/dart-lang/dart2js_info/commit/74a8f92d96f926f84ff2b988ad24715b87546420

[Siggi Cherem (dart-lang), 2016-11-01 22:41:00]

sigmund@google.com changed reviewers:
+ het@google.com

[Siggi Cherem (dart-lang), 2016-11-01 23:07:35]

OK - I updated the CL. The output now looks like this:


Output unit main:
  loaded by default
  contains:
     - hello_world.dart
     - dart:core
     - dart:_internal
     - dart:_js_primitives
     - dart:_js_helper
     - dart:collection
     - dart:_interceptors
     - dart:_isolate_helper
     - dart:async
     - dart:_js_names
     - dart:_foreign_helper
     - dart:_js_embedded_names
     - dart:isolate
     - dart:_async_await_error_codes

Output unit 2:
  loaded by importing: [b]
  contains:
     - c.dart:
       - function d
     - b.dart

Output unit 1:
  loaded by importing: [a]
  contains:
     - c.dart:
       - function c
     - a.dart

[Harry Terkelsen, 2016-11-01 23:18:29]

I see some typos in type names. Please run this in checked mode

https://codereview.chromium.org/2469963002/diff/20001/README.md
File README.md (right):

https://codereview.chromium.org/2469963002/diff/20001/README.md#newcode81
README.md:81: * [`deferred_library_layout`][deferred_layout]: a tool that
reports which
also write up an example with example output and explain that if every member of
a lib is in one chunk it won't list out the sub-functions, otherwise it will

https://codereview.chromium.org/2469963002/diff/20001/bin/deferred_library_la...
File bin/deferred_library_layout.dart (right):

https://codereview.chromium.org/2469963002/diff/20001/bin/deferred_library_la...
bin/deferred_library_layout.dart:15: Map<OutputUnifInfo, Map<LibraryInfo,
List<BasicInfo>>> hunkMembers = {};
s/OutputUnifInfo/OutputUnitInfo/

https://codereview.chromium.org/2469963002/diff/20001/bin/deferred_library_la...
bin/deferred_library_layout.dart:16: Map<LibraryInfo, Set<OuputUnitInfo>>
libToHunks = {};
s/OuputUnitInfo/OutputUnitInfo/

https://codereview.chromium.org/2469963002/diff/20001/bin/deferred_library_la...
bin/deferred_library_layout.dart:18: if (info.outputUnit == null) return;
do you see this in practice? I think all basicinfos should have an output unit

[Siggi Cherem (dart-lang), 2016-11-01 23:26:55]

Thanks Harry!

https://codereview.chromium.org/2469963002/diff/20001/README.md
File README.md (right):

https://codereview.chromium.org/2469963002/diff/20001/README.md#newcode81
README.md:81: * [`deferred_library_layout`][deferred_layout]: a tool that
reports which
On 2016/11/01 23:18:29, Harry Terkelsen wrote:
> also write up an example with example output and explain that if every member
of
> a lib is in one chunk it won't list out the sub-functions, otherwise it will

done, added a full section further below.

https://codereview.chromium.org/2469963002/diff/20001/bin/deferred_library_la...
File bin/deferred_library_layout.dart (right):

https://codereview.chromium.org/2469963002/diff/20001/bin/deferred_library_la...
bin/deferred_library_layout.dart:15: Map<OutputUnifInfo, Map<LibraryInfo,
List<BasicInfo>>> hunkMembers = {};
On 2016/11/01 23:18:29, Harry Terkelsen wrote:
> s/OutputUnifInfo/OutputUnitInfo/

ha - checked mode didn't get those because the underlying types where dynamic :)

 I'm running the analyzer now, all looks clean.

https://codereview.chromium.org/2469963002/diff/20001/bin/deferred_library_la...
bin/deferred_library_layout.dart:16: Map<LibraryInfo, Set<OuputUnitInfo>>
libToHunks = {};
On 2016/11/01 23:18:29, Harry Terkelsen wrote:
> s/OuputUnitInfo/OutputUnitInfo/

Done.

https://codereview.chromium.org/2469963002/diff/20001/bin/deferred_library_la...
bin/deferred_library_layout.dart:18: if (info.outputUnit == null) return;
On 2016/11/01 23:18:29, Harry Terkelsen wrote:
> do you see this in practice? I think all basicinfos should have an output unit

Yes, but I think only for library infos. Maybe we don't need this if I skip the
libraries below.

[Harry Terkelsen, 2016-11-01 23:30:39]

lgtm

https://codereview.chromium.org/2469963002/diff/20001/bin/deferred_library_la...
File bin/deferred_library_layout.dart (right):

https://codereview.chromium.org/2469963002/diff/20001/bin/deferred_library_la...
bin/deferred_library_layout.dart:18: if (info.outputUnit == null) return;
On 2016/11/01 23:26:54, Siggi Cherem (dart-lang) wrote:
> On 2016/11/01 23:18:29, Harry Terkelsen wrote:
> > do you see this in practice? I think all basicinfos should have an output
unit
> 
> Yes, but I think only for library infos. Maybe we don't need this if I skip
the
> libraries below.

I think we should skip libraries and the null check.

https://codereview.chromium.org/2469963002/diff/30001/README.md
File README.md (right):

https://codereview.chromium.org/2469963002/diff/30001/README.md#newcode278
README.md:278: This tool reports which code is included on each output unit.  It
can be run as
on -> in

https://codereview.chromium.org/2469963002/diff/30001/README.md#newcode289
README.md:289: which elements are on one or another output unit. For example,
the output might
on -> in

[Siggi Cherem (dart-lang), 2016-11-01 23:37:43]

Thanks Harry!

https://codereview.chromium.org/2469963002/diff/20001/bin/deferred_library_la...
File bin/deferred_library_layout.dart (right):

https://codereview.chromium.org/2469963002/diff/20001/bin/deferred_library_la...
bin/deferred_library_layout.dart:18: if (info.outputUnit == null) return;
On 2016/11/01 23:30:39, Harry Terkelsen wrote:
> On 2016/11/01 23:26:54, Siggi Cherem (dart-lang) wrote:
> > On 2016/11/01 23:18:29, Harry Terkelsen wrote:
> > > do you see this in practice? I think all basicinfos should have an output
> unit
> > 
> > Yes, but I think only for library infos. Maybe we don't need this if I skip
> the
> > libraries below.
> 
> I think we should skip libraries and the null check.

Done.

https://codereview.chromium.org/2469963002/diff/30001/README.md
File README.md (right):

https://codereview.chromium.org/2469963002/diff/30001/README.md#newcode278
README.md:278: This tool reports which code is included on each output unit.  It
can be run as
On 2016/11/01 23:30:39, Harry Terkelsen wrote:
> on -> in

Done.

https://codereview.chromium.org/2469963002/diff/30001/README.md#newcode289
README.md:289: which elements are on one or another output unit. For example,
the output might
On 2016/11/01 23:30:39, Harry Terkelsen wrote:
> on -> in

Done.

[Siggi Cherem (dart-lang), 2016-11-01 23:37:52]

Description was changed from

==========
Add defer-layout tool.

This is a simple tool to tell you how libraries map to output units. Here is an
example output of the tool:

  Output unit main:
    loaded by default
    contains:
       - hello_world.dart
       - dart:core
       - dart:_internal
       - dart:_js_primitives
       - dart:_js_helper
       - dart:collection
       - dart:_interceptors
       - dart:_isolate_helper
       - dart:async
       - dart:_js_names
       - dart:_foreign_helper
       - dart:_js_embedded_names
       - dart:isolate
       - dart:_async_await_error_codes

  Output unit 2:
    loaded by importing: [a, b]
    contains:
       - c.dart

  Output unit 1:
    loaded by importing: [a]
    contains:
       - a.dart

  Output unit 3:
    loaded by importing: [b]
    contains:
       - b.dart

BUG=
==========

to

==========
Add defer-layout tool.

This is a simple tool to tell you how libraries map to output units. Here is an
example output of the tool:

  Output unit main:
    loaded by default
    contains:
       - hello_world.dart
       - dart:core
       - dart:_internal
       - dart:_js_primitives
       - dart:_js_helper
       - dart:collection
       - dart:_interceptors
       - dart:_isolate_helper
       - dart:async
       - dart:_js_names
       - dart:_foreign_helper
       - dart:_js_embedded_names
       - dart:isolate
       - dart:_async_await_error_codes

  Output unit 2:
    loaded by importing: [a, b]
    contains:
       - c.dart

  Output unit 1:
    loaded by importing: [a]
    contains:
       - a.dart

  Output unit 3:
    loaded by importing: [b]
    contains:
       - b.dart

BUG=
R=het@google.com

Committed:
https://github.com/dart-lang/dart2js_info/commit/74a8f92d96f926f84ff2b988ad24...
==========

[Siggi Cherem (dart-lang), 2016-11-01 23:37:53]

Committed patchset #4 (id:50001) manually as
74a8f92d96f926f84ff2b988ad24715b87546420 (presubmit successful).