Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 24695003: Fix optimized Math.pow on x64 with NaN exponents. (Closed)

Created:
7 years, 2 months ago by Florian Schneider
Modified:
7 years, 2 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix optimized Math.pow on x64 with NaN exponents. The libc implementation used by the optimized code differs from the expected behaviour. It does not return double.NaN as the Dart implementation of pow when the exponent is NaN. The test fails when running with a low optimization-counter-threshold=5. BUG=https://code.google.com/p/dart/issues/detail?id=13543 TEST=math/double_pow_test R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=27950

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M runtime/vm/intermediate_language_x64.cc View 1 2 chunks +10 lines, -4 lines 0 comments Download
M tests/lib/lib.status View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Florian Schneider
7 years, 2 months ago (2013-09-26 13:03:16 UTC) #1
srdjan
LGTM https://codereview.chromium.org/24695003/diff/1/runtime/vm/intermediate_language_x64.cc File runtime/vm/intermediate_language_x64.cc (right): https://codereview.chromium.org/24695003/diff/1/runtime/vm/intermediate_language_x64.cc#newcode4259 runtime/vm/intermediate_language_x64.cc:4259: __ movsd(result, exp); Add comment: result is NaN
7 years, 2 months ago (2013-09-26 13:09:22 UTC) #2
Florian Schneider
Thanks for the quick review. https://codereview.chromium.org/24695003/diff/1/runtime/vm/intermediate_language_x64.cc File runtime/vm/intermediate_language_x64.cc (right): https://codereview.chromium.org/24695003/diff/1/runtime/vm/intermediate_language_x64.cc#newcode4259 runtime/vm/intermediate_language_x64.cc:4259: __ movsd(result, exp); On ...
7 years, 2 months ago (2013-09-26 13:11:28 UTC) #3
Florian Schneider
7 years, 2 months ago (2013-09-26 13:13:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r27950 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698