Add HttpClient:put/delete/head/patch.

Add HttpClient:put/delete/head/patch.

BUG=http://code.google.com/p/dart/issues/detail?id=18168
R=lrn@google.com, sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=35252

[Søren Gjesse, 2014-04-22 08:27:20]

Do we need to add these? open/openUrl can be used to specify any method.

https://codereview.chromium.org/246923003/diff/1/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/246923003/diff/1/sdk/lib/io/http_impl.dart#ne...
sdk/lib/io/http_impl.dart:1552: Future<HttpClientRequest> get(String host, int
port, String path)
We normally only use => when it fits one line.

[Anders Johnsen, 2014-04-22 08:30:22]

While not critical, I find it odd to provide both get and post, but not the rest
of these REST-related APIs. Likewise, I think we should consider adding head as
well. 'open' can be somewhat odd to approach as a user.

[Søren Gjesse, 2014-04-22 08:37:08]

On 2014/04/22 08:30:22, Anders Johnsen wrote:
> While not critical, I find it odd to provide both get and post, but not the
rest
> of these REST-related APIs. Likewise, I think we should consider adding head
as
> well. 'open' can be somewhat odd to approach as a user.

What about PATCH then? It is also sometimes used for REST APIs.

[Lasse Reichstein Nielsen, 2014-04-22 08:49:47]

lgtm

https://codereview.chromium.org/246923003/diff/1/sdk/lib/io/http.dart
File sdk/lib/io/http.dart (right):

https://codereview.chromium.org/246923003/diff/1/sdk/lib/io/http.dart#newcode...
sdk/lib/io/http.dart:1359: /**
Please also add "HEAD" support.
I don't think TRACE and OPTIONS are important here, but HEAD can often be
useful.

https://codereview.chromium.org/246923003/diff/1/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/246923003/diff/1/sdk/lib/io/http_impl.dart#ne...
sdk/lib/io/http_impl.dart:1552: Future<HttpClientRequest> get(String host, int
port, String path)
I fully accept the two-line case, as long as the body expression fits on one
line.
Indent by four, though.

https://codereview.chromium.org/246923003/diff/1/sdk/lib/io/http_impl.dart#ne...
sdk/lib/io/http_impl.dart:1558: => open("post", host, port, path);
Indent by four.
More below.

https://codereview.chromium.org/246923003/diff/1/tests/standalone/io/http_cli...
File tests/standalone/io/http_client_connect_test.dart (right):

https://codereview.chromium.org/246923003/diff/1/tests/standalone/io/http_cli...
tests/standalone/io/http_client_connect_test.dart:199: }
Test putUrl and deleteUrl?

[Søren Gjesse, 2014-04-22 09:02:07]

lgtm - I rest my case, but lets add HEAD and PATCH as well then.

[Anders Johnsen, 2014-04-22 10:58:35]

https://codereview.chromium.org/246923003/diff/1/sdk/lib/io/http.dart
File sdk/lib/io/http.dart (right):

https://codereview.chromium.org/246923003/diff/1/sdk/lib/io/http.dart#newcode...
sdk/lib/io/http.dart:1359: /**
On 2014/04/22 08:49:47, Lasse Reichstein Nielsen wrote:
> Please also add "HEAD" support.
> I don't think TRACE and OPTIONS are important here, but HEAD can often be
> useful. 

Done.

https://codereview.chromium.org/246923003/diff/1/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/246923003/diff/1/sdk/lib/io/http_impl.dart#ne...
sdk/lib/io/http_impl.dart:1552: Future<HttpClientRequest> get(String host, int
port, String path)
On 2014/04/22 08:49:47, Lasse Reichstein Nielsen wrote:
> I fully accept the two-line case, as long as the body expression fits on one
> line.
> Indent by four, though.

Done.

https://codereview.chromium.org/246923003/diff/1/sdk/lib/io/http_impl.dart#ne...
sdk/lib/io/http_impl.dart:1558: => open("post", host, port, path);
On 2014/04/22 08:49:47, Lasse Reichstein Nielsen wrote:
> Indent by four.
> More below.

Done.

https://codereview.chromium.org/246923003/diff/1/tests/standalone/io/http_cli...
File tests/standalone/io/http_client_connect_test.dart (right):

https://codereview.chromium.org/246923003/diff/1/tests/standalone/io/http_cli...
tests/standalone/io/http_client_connect_test.dart:199: }
On 2014/04/22 08:49:47, Lasse Reichstein Nielsen wrote:
> Test putUrl and deleteUrl?

Done.

[Anders Johnsen, 2014-04-22 10:58:57]

Committed patchset #3 manually as r35252 (presubmit successful).