Issue 246833003: Revert "Remove unmodifiable map wrappers that could instead use UnmodifiableMapView."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 246833003: Revert "Remove unmodifiable map wrappers that could instead use UnmodifiableMapView." (Closed)

Created:
6 years, 8 months ago by Lasse Reichstein Nielsen

Modified:
6 years, 8 months ago

Reviewers:

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Revert "Remove unmodifiable map wrappers that could instead use UnmodifiableMapView." Some tests fail. Committed: https://code.google.com/p/dart/source/detail?r=35245

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+167 lines, -32 lines)			Patch
M	pkg/template_binding/test/custom_element_bindings_test.dart	View	1 chunk	+20 lines, -4 lines	0 comments	Download
M	pkg/yaml/lib/src/yaml_map.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/lib/mirrors_impl.dart	View	7 chunks	+34 lines, -8 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/mirrors/util.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/lib/js_mirrors.dart	View	2 chunks	+40 lines, -2 lines	0 comments	Download
M	sdk/lib/core/uri.dart	View	2 chunks	+31 lines, -1 line	0 comments	Download
M	sdk/lib/io/http_headers.dart	View	5 chunks	+39 lines, -11 lines	0 comments	Download
M	sdk/lib/io/io.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	sdk/lib/io/platform_impl.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 1 (0 generated)

Lasse Reichstein Nielsen

6 years, 8 months ago (2014-04-22 06:21:39 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r35245 (presubmit successful).