Issue 24680006: Fix list length optimization bug: do not inline a length access to a constant if the receiver can b…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24680006: Fix list length optimization bug: do not inline a length access to a constant if the receiver can b… (Closed)

Created:
7 years, 2 months ago by ngeoffray

Modified:
7 years, 2 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Fix list length optimization bug: do not inline a length access to a constant if the receiver can be null. Committed: https://code.google.com/p/dart/source/detail?r=27989

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -11 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/ssa/optimize.dart	View	1	1 chunk	+11 lines, -1 line	0 comments	Download
	A +	tests/language/list_length_tracer_test.dart	View		2 chunks	+4 lines, -10 lines	0 comments	Download

Total messages: 5 (0 generated)

ngeoffray

Thanks Kasper. As discussed, I updated the code to continue doing the length access -> ...

7 years, 2 months ago (2013-09-27 06:40:08 UTC) #3

ngeoffray

7 years, 2 months ago (2013-09-27 07:08:19 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r27989 (presubmit successful).