Issue 24673003: Treat final variables initialized with a literal as constants. Also sneak in a small cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24673003: Treat final variables initialized with a literal as constants. Also sneak in a small cleanup. (Closed)

Created:
7 years, 2 months ago by srdjan

Modified:
7 years, 2 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org, siva

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Treat final variables initialized with a literal as constants. Also sneak in a small cleanup. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=27973

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	runtime/lib/string.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	runtime/vm/parser.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

srdjan

Committed patchset #1 manually as r27973 (presubmit successful).

7 years, 2 months ago (2013-09-26 21:07:00 UTC) #4

srdjan

7 years, 2 months ago (2013-09-26 21:07:44 UTC) #5

Message was sent while issue was closed.

Committed only the string.cc cleanup since attempting to do a more general
solution for string interpolation.