Issue 246633006: Revert "JS templates"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 246633006: Revert "JS templates" (Closed)

Created:
6 years, 8 months ago by sra1

Modified:
6 years, 8 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "JS templates" TBR=floitsch@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=35299

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1138 lines, -1949 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/js/builder.dart	View	17 chunks	+305 lines, -351 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js/js.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js/nodes.dart	View	4 chunks	+95 lines, -49 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js/printer.dart	View	2 chunks	+7 lines, -20 lines	0 comments	Download
D	sdk/lib/_internal/compiler/implementation/js/template.dart	View	1 chunk	+0 lines, -676 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart	View	5 chunks	+18 lines, -14 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart	View	4 chunks	+11 lines, -8 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart	View	7 chunks	+30 lines, -48 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart	View	13 chunks	+338 lines, -309 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart	View	13 chunks	+31 lines, -35 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_emitter/interceptor_emitter.dart	View	11 chunks	+120 lines, -80 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_emitter/metadata_emitter.dart	View	3 chunks	+5 lines, -5 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_emitter/nsm_emitter.dart	View	4 chunks	+102 lines, -117 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart	View	3 chunks	+9 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/native_handler.dart	View	4 chunks	+7 lines, -14 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	14 chunks	+17 lines, -29 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/codegen.dart	View	5 chunks	+28 lines, -26 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/nodes.dart	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/ssa_tracer.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/lib/isolate_helper.dart	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	sdk/lib/_internal/lib/js_helper.dart	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/lib/js_mirrors.dart	View	1 chunk	+2 lines, -7 lines	0 comments	Download
D	tests/compiler/dart2js/js_parser_statements_test.dart	View	1 chunk	+0 lines, -145 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sra1

Committed patchset #1 manually as r35299 (presubmit successful).

6 years, 8 months ago (2014-04-23 03:42:10 UTC) #1

Message was sent while issue was closed.

lgtm.

Expand Messages | Collapse Messages