Use AnalysisServer.running only to track whether server has been shut down.

Use AnalysisServer.running only to track whether server has been shut down.

Previously, AnalysisServer.run() and AnalysisServer.performTask() also
tried to use this variable to track whether there was a pending call
to performTask() on the event queue.  The resulting confusion
prevented analysis from ever running.

It turns out that we don't need to separately track whether there is a
pending call to performTask(), as long as we enforce the invariant
that there is a pending call to performTask() exactly when
contextWorkQueue is non-empty.

R=brianwilkerson@google.com, danrubel@google.com

Committed: https://code.google.com/p/dart/source/detail?r=35323

[Paul Berry, 2014-04-22 20:28:36]

I'm not thrilled about the amount of boilerplate code I had to write in order to
create MockAnalysisContext.  I'm definitely open to suggestions for better was
to accomplish this.

[Brian Wilkerson, 2014-04-22 22:46:03]

LGTM

https://codereview.chromium.org/246603005/diff/1/pkg/analysis_server/test/moc...
File pkg/analysis_server/test/mocks.dart (right):

https://codereview.chromium.org/246603005/diff/1/pkg/analysis_server/test/moc...
pkg/analysis_server/test/mocks.dart:170: class MockAnalysisLogger extends Logger
{
Try the following

@proxy
class MockAnalysisLogger implements Logger {
  noSuchMethod(Invocation invocation) => _unexpected();
}

You could even implement _unexpected to take an Invocation and produce a better
error message (such as which method was invoked and on which class).

https://codereview.chromium.org/246603005/diff/1/pkg/analysis_server/test/moc...
pkg/analysis_server/test/mocks.dart:192: class MockAnalysisContext extends
AnalysisContext {
Likewise:

@proxy
class MockAnalysisContext implements AnalysisContext {
  noSuchMethod(Invocation invocation) => _unexpected();
}

[danrubel, 2014-04-23 02:04:21]

LGTM

[Paul Berry, 2014-04-23 18:36:02]

Committed patchset #1 manually as r35323 (presubmit successful).

[Paul Berry, 2014-04-23 18:36:26]

https://codereview.chromium.org/246603005/diff/1/pkg/analysis_server/test/moc...
File pkg/analysis_server/test/mocks.dart (right):

https://codereview.chromium.org/246603005/diff/1/pkg/analysis_server/test/moc...
pkg/analysis_server/test/mocks.dart:170: class MockAnalysisLogger extends Logger
{
On 2014/04/22 22:46:03, Brian Wilkerson wrote:
> Try the following
> 
> @proxy
> class MockAnalysisLogger implements Logger {
>   noSuchMethod(Invocation invocation) => _unexpected();
> }
> 
> You could even implement _unexpected to take an Invocation and produce a
better
> error message (such as which method was invoked and on which class).

Done, thanks.