Fixes docgen build step on Windows.

Fixes docgen build step on Windows.
Also addresses dartbug.com/4989 by using docgen from freshly created sdk.

BUG=dartbug.com/4989
BUG=dartbug.com/18392
R=alanknight@google.com, ricow@google.com

Committed: https://code.google.com/p/dart/source/detail?r=35348

[ricow1, 2014-04-23 11:38:00]

DBC, LGTM if comments addressed, but please also let Alan have a look since I
may be missing something about how docgen works

https://chromiumcodereview.appspot.com/246563005/diff/10001/utils/apidoc/docg...
File utils/apidoc/docgen.gyp (right):

https://chromiumcodereview.appspot.com/246563005/diff/10001/utils/apidoc/docg...
utils/apidoc/docgen.gyp:66: '../../tools/only_in_release_mode.py',
If you want to do this you need to put
'<(PRODUCT_DIR)/dart-sdk/README',
here (having a dependency just means that dependency will be build, not that it
is build before this, if you have the output of a dependency as input it will be
part of the generation tree)

https://chromiumcodereview.appspot.com/246563005/diff/10001/utils/apidoc/docg...
utils/apidoc/docgen.gyp:67: ],
we also need to have packages as input, as stated on
https://codereview.chromium.org/237443004/ this is best done by having a
dependency on on ../../pkg/pkg_files.gyp:pkg_files_stamp and in input have
'<(SHARED_INTERMEDIATE_DIR)/pkg_files.stamp',

https://chromiumcodereview.appspot.com/246563005/diff/10001/utils/apidoc/docg...
utils/apidoc/docgen.gyp:76:
'<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)dart-sdk/bin/docgen<(script_suffix)',
why executable prefix here?

[aam-me, 2014-04-23 12:07:10]

Thank you Rico. Addressed your comments.

https://chromiumcodereview.appspot.com/246563005/diff/10001/utils/apidoc/docg...
File utils/apidoc/docgen.gyp (right):

https://chromiumcodereview.appspot.com/246563005/diff/10001/utils/apidoc/docg...
utils/apidoc/docgen.gyp:66: '../../tools/only_in_release_mode.py',
Ah, that explains sporadic failures I have seen around create-sdk, when it was
trying to override binaries somebody else was actually using. Good to know.
Done.

https://chromiumcodereview.appspot.com/246563005/diff/10001/utils/apidoc/docg...
utils/apidoc/docgen.gyp:67: ],
On 2014/04/23 11:38:01, ricow1 wrote:
> we also need to have packages as input, as stated on
> https://codereview.chromium.org/237443004/ this is best done by having a
> dependency on on ../../pkg/pkg_files.gyp:pkg_files_stamp and in input have
> '<(SHARED_INTERMEDIATE_DIR)/pkg_files.stamp',

Done.

https://chromiumcodereview.appspot.com/246563005/diff/10001/utils/apidoc/docg...
utils/apidoc/docgen.gyp:76:
'<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)dart-sdk/bin/docgen<(script_suffix)',
On 2014/04/23 11:38:01, ricow1 wrote:
> why executable prefix here?

Removed.

[Alan Knight, 2014-04-23 17:13:04]

I don't know that I'm going to catch anything in gyp that you miss, but LGTM.
And I think this is preferable, using the snapshot, rather than fixing up the
invocation as a dart file.

[aam-me, 2014-04-24 01:07:57]

Committed patchset #3 manually as r35348 (presubmit successful).