Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 24653006: Adding Element.created constructor (Closed)

Created:
7 years, 2 months ago by blois
Modified:
7 years, 2 months ago
Reviewers:
vsm, sra1
CC:
reviews_dartlang.org, Jennifer Messerly, sra1
Visibility:
Public.

Description

Adding Element.created constructor and .created constructors to all subclasses. Also ensuring generative constructor for all superclasses. This is for post-construction custom element creation. Element.created is public, then the base classes of that get private ._created constructors. BUG= R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=28120

Patch Set 1 : #

Patch Set 2 : Adding createCallback to custom_element.dart #

Total comments: 4

Patch Set 3 : Testing global error fixes #

Patch Set 4 : #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+2307 lines, -21 lines) Patch
M pkg/custom_element/lib/custom_element.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/unittest/lib/html_config.dart View 1 2 2 chunks +7 lines, -1 line 2 comments Download
M pkg/unittest/lib/test_controller.js View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 79 chunks +471 lines, -3 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 80 chunks +474 lines, -2 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 1 2 3 87 chunks +522 lines, -0 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 1 2 3 87 chunks +522 lines, -0 lines 0 comments Download
M tests/html/custom/attribute_changed_callback_test.dart View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M tests/html/custom/constructor_calls_created_synchronously_test.dart View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M tests/html/custom/created_callback_test.dart View 1 2 3 5 chunks +207 lines, -7 lines 2 comments Download
M tests/html/custom/document_register_basic_test.dart View 1 2 3 4 chunks +4 lines, -0 lines 0 comments Download
M tests/html/custom/document_register_type_extensions_test.dart View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M tests/html/custom/entered_left_view_test.dart View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M tests/html/custom_elements_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/html/html.status View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download
M tools/dom/src/dart2js_CustomElementSupport.dart View 2 chunks +6 lines, -1 line 0 comments Download
M tools/dom/src/native_DOMImplementation.dart View 3 chunks +10 lines, -0 lines 0 comments Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Document.darttemplate View 1 chunk +0 lines, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 1 2 3 2 chunks +25 lines, -1 line 2 comments Download
M tools/dom/templates/html/impl/impl_EventTarget.darttemplate View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Node.darttemplate View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
blois
7 years, 2 months ago (2013-09-30 19:03:33 UTC) #1
vsm
On 2013/09/30 19:03:33, blois wrote: QQ: is createdCallback going away? It seems redundant with the ...
7 years, 2 months ago (2013-09-30 22:48:00 UTC) #2
blois
On 2013/09/30 22:48:00, vsm wrote: > On 2013/09/30 19:03:33, blois wrote: > > QQ: is ...
7 years, 2 months ago (2013-09-30 22:57:37 UTC) #3
sra1
https://codereview.chromium.org/24653006/diff/20001/tests/html/custom/attribute_changed_callback_test.dart File tests/html/custom/attribute_changed_callback_test.dart (right): https://codereview.chromium.org/24653006/diff/20001/tests/html/custom/attribute_changed_callback_test.dart#newcode13 tests/html/custom/attribute_changed_callback_test.dart:13: A.created(): super.created(); Style elsewhere is a space precedes ":" ...
7 years, 2 months ago (2013-10-01 02:37:04 UTC) #4
blois
https://codereview.chromium.org/24653006/diff/20001/tests/html/custom/attribute_changed_callback_test.dart File tests/html/custom/attribute_changed_callback_test.dart (right): https://codereview.chromium.org/24653006/diff/20001/tests/html/custom/attribute_changed_callback_test.dart#newcode13 tests/html/custom/attribute_changed_callback_test.dart:13: A.created(): super.created(); On 2013/10/01 02:37:04, sra1 wrote: > Style ...
7 years, 2 months ago (2013-10-01 16:36:19 UTC) #5
vsm
lgtm https://chromiumcodereview.appspot.com/24653006/diff/31001/pkg/unittest/lib/html_config.dart File pkg/unittest/lib/html_config.dart (right): https://chromiumcodereview.appspot.com/24653006/diff/31001/pkg/unittest/lib/html_config.dart#newcode106 pkg/unittest/lib/html_config.dart:106: if (js.context['testExpectsGlobalError'] != true) { Perhaps it makes ...
7 years, 2 months ago (2013-10-01 16:57:59 UTC) #6
blois
https://chromiumcodereview.appspot.com/24653006/diff/31001/pkg/unittest/lib/html_config.dart File pkg/unittest/lib/html_config.dart (right): https://chromiumcodereview.appspot.com/24653006/diff/31001/pkg/unittest/lib/html_config.dart#newcode106 pkg/unittest/lib/html_config.dart:106: if (js.context['testExpectsGlobalError'] != true) { On 2013/10/01 16:58:01, vsm ...
7 years, 2 months ago (2013-10-01 20:37:07 UTC) #7
blois
7 years, 2 months ago (2013-10-01 21:26:17 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 manually as r28120 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698