Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 24650002: Add test for conflicts between type variables and instance or static getters, methods or fields. (Closed)

Created:
7 years, 2 months ago by rmacnak
Modified:
7 years, 2 months ago
Reviewers:
gbracha
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add test for conflicts between type variables and instance or static getters, methods or fields. R=gbracha@google.com Committed: https://code.google.com/p/dart/source/detail?r=28413

Patch Set 1 #

Total comments: 1

Patch Set 2 : static #

Patch Set 3 : added issue numbers #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -0 lines) Patch
M tests/language/language.status View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
A tests/language/type_variable_conflict_test.dart View 1 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rmacnak
7 years, 2 months ago (2013-09-25 19:36:46 UTC) #1
gbracha
https://codereview.chromium.org/24650002/diff/1/tests/language/type_variable_conflict_test.dart File tests/language/type_variable_conflict_test.dart (right): https://codereview.chromium.org/24650002/diff/1/tests/language/type_variable_conflict_test.dart#newcode21 tests/language/type_variable_conflict_test.dart:21: } The last 3 are the same as the ...
7 years, 2 months ago (2013-09-25 20:23:26 UTC) #2
rmacnak
On 2013/09/25 20:23:26, gbracha wrote: > https://codereview.chromium.org/24650002/diff/1/tests/language/type_variable_conflict_test.dart > File tests/language/type_variable_conflict_test.dart (right): > > https://codereview.chromium.org/24650002/diff/1/tests/language/type_variable_conflict_test.dart#newcode21 > ...
7 years, 2 months ago (2013-09-27 17:51:31 UTC) #3
rmacnak
added issue numbers
7 years, 2 months ago (2013-10-09 01:50:54 UTC) #4
gbracha
lgtm
7 years, 2 months ago (2013-10-09 01:53:50 UTC) #5
rmacnak
7 years, 2 months ago (2013-10-09 20:07:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 manually as r28413 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698