Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 24645002: added bool type to named args in lib/io and lib/_internal (Closed)

Created:
7 years, 2 months ago by kevmoo-old
Modified:
7 years, 2 months ago
CC:
reviews_dartlang.org, ahe, Søren Thygesen Gjesse
Visibility:
Public.

Description

added bool type to named args in lib/io and lib/_internal R=ahe@google.com, floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=27946

Patch Set 1 #

Total comments: 1

Patch Set 2 : long line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -18 lines) Patch
M sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/elements.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/modelx.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/io.dart View 1 2 chunks +3 lines, -2 lines 0 comments Download
M sdk/lib/io/directory.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/io/directory_impl.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/io/file_system_entity.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/io/http_impl.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
kevmoo-old
Noticed the docs were missing these. Did a quick grep for other obvious instances in ...
7 years, 2 months ago (2013-09-25 19:13:03 UTC) #1
floitsch
LGTM. https://codereview.chromium.org/24645002/diff/1/sdk/lib/_internal/pub/lib/src/io.dart File sdk/lib/_internal/pub/lib/src/io.dart (right): https://codereview.chromium.org/24645002/diff/1/sdk/lib/_internal/pub/lib/src/io.dart#newcode153 sdk/lib/_internal/pub/lib/src/io.dart:153: String writeTextFile(String file, String contents, {bool dontLogContents: false}) ...
7 years, 2 months ago (2013-09-26 11:33:44 UTC) #2
ahe
Thank you. LGTM!
7 years, 2 months ago (2013-09-26 11:38:34 UTC) #3
kevmoo-old
7 years, 2 months ago (2013-09-26 12:29:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r27946 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698