Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 24644004: Fix bug in container tracer, where a local would be updated with the wrong type in the expression `… (Closed)

Created:
7 years, 2 months ago by ngeoffray
Modified:
7 years, 2 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix bug in container tracer, where a local would be updated with the wrong type in the expression `a += 42`. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=27932

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -11 lines) Patch
M sdk/lib/_internal/compiler/implementation/inferrer/container_tracer.dart View 1 chunk +10 lines, -7 lines 0 comments Download
A + tests/compiler/dart2js/list_tracer3_test.dart View 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
7 years, 2 months ago (2013-09-25 20:50:49 UTC) #1
kasperl
LGTM.
7 years, 2 months ago (2013-09-26 05:22:46 UTC) #2
ngeoffray
7 years, 2 months ago (2013-09-26 07:20:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r27932 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698