Enables first codegen test on arm64.

Enables first codegen test on arm64.

R=regis@google.com

Committed: https://code.google.com/p/dart/source/detail?r=35317

[regis, 2014-04-22 23:38:10]

LGTM

https://codereview.chromium.org/246293010/diff/1/runtime/vm/assembler_arm64.h
File runtime/vm/assembler_arm64.h (right):

https://codereview.chromium.org/246293010/diff/1/runtime/vm/assembler_arm64.h...
runtime/vm/assembler_arm64.h:557: cmp(SP, Operand(rm, UXTX, 0));
I suppose you have an assert in cmp() making sure that we do not use SP without
UXTX 0. Someone hitting that assert will be puzzled. A hint to use UXTX 0 may
help.

https://codereview.chromium.org/246293010/diff/1/runtime/vm/assembler_x64.cc
File runtime/vm/assembler_x64.cc (right):

https://codereview.chromium.org/246293010/diff/1/runtime/vm/assembler_x64.cc#...
runtime/vm/assembler_x64.cc:2902: Register new_pp, Register new_pc) {
new_pc is not a good name. It is more like a pc_marker_override.

https://codereview.chromium.org/246293010/diff/1/runtime/vm/assembler_x64.cc#...
runtime/vm/assembler_x64.cc:2904: EnterDartFrame(frame_size);
bug?

https://codereview.chromium.org/246293010/diff/1/runtime/vm/flow_graph_compil...
File runtime/vm/flow_graph_compiler_arm64.cc (right):

https://codereview.chromium.org/246293010/diff/1/runtime/vm/flow_graph_compil...
runtime/vm/flow_graph_compiler_arm64.cc:350: // the CodePatcher.
Sorry, I do not know or do not remember. Ask Srdjan.

https://codereview.chromium.org/246293010/diff/1/runtime/vm/intermediate_lang...
File runtime/vm/intermediate_language_arm64.cc (right):

https://codereview.chromium.org/246293010/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_arm64.cc:68: __ sub(R2, SP, Operand(FP, UXTX,
0));
I suppose you have an assert in sub(), add(), etc.. making sure that we do not
use SP without UXTX 0. Someone hitting that assert will be puzzled. A hint to
use UXTX 0 may help.

[zra, 2014-04-23 17:18:45]

Thanks!

https://codereview.chromium.org/246293010/diff/1/runtime/vm/assembler_arm64.h
File runtime/vm/assembler_arm64.h (right):

https://codereview.chromium.org/246293010/diff/1/runtime/vm/assembler_arm64.h...
runtime/vm/assembler_arm64.h:557: cmp(SP, Operand(rm, UXTX, 0));
On 2014/04/22 23:38:10, regis wrote:
> I suppose you have an assert in cmp() making sure that we do not use SP
without
> UXTX 0. Someone hitting that assert will be puzzled. A hint to use UXTX 0 may
> help.

The relevant asserts are in AddSubHelper. I've added comments elsewhere to
exlain.

https://codereview.chromium.org/246293010/diff/1/runtime/vm/assembler_x64.cc
File runtime/vm/assembler_x64.cc (right):

https://codereview.chromium.org/246293010/diff/1/runtime/vm/assembler_x64.cc#...
runtime/vm/assembler_x64.cc:2902: Register new_pp, Register new_pc) {
On 2014/04/22 23:38:10, regis wrote:
> new_pc is not a good name. It is more like a pc_marker_override.

Done.

https://codereview.chromium.org/246293010/diff/1/runtime/vm/assembler_x64.cc#...
runtime/vm/assembler_x64.cc:2904: EnterDartFrame(frame_size);
On 2014/04/22 23:38:10, regis wrote:
> bug?

I assume so, but I think we must have never passed anything non-zero to
EnterDartFrameWithInfo.

https://codereview.chromium.org/246293010/diff/1/runtime/vm/intermediate_lang...
File runtime/vm/intermediate_language_arm64.cc (right):

https://codereview.chromium.org/246293010/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_arm64.cc:68: __ sub(R2, SP, Operand(FP, UXTX,
0));
On 2014/04/22 23:38:10, regis wrote:
> I suppose you have an assert in sub(), add(), etc.. making sure that we do not
> use SP without UXTX 0. Someone hitting that assert will be puzzled. A hint to
> use UXTX 0 may help.

Asserts in AddSubHelper. Comments added ad sub, add, etc.

[zra, 2014-04-23 17:50:50]

Committed patchset #2 manually as r35317 (presubmit successful).