Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 246253004: Remove suppression for lib/mirrors/invoke_natives_fuzz_test on dart2js (Closed)

Created:
6 years, 8 months ago by ricow1
Modified:
6 years, 8 months ago
Reviewers:
rmacnak, floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove suppression for lib/mirrors/invoke_natives_fuzz_test on dart2js This is passing on all configurations as far as I can see Also, I don't really see why the second of the removed headings is needed, since it seems to be containted in the first This may be due to commit - status file update - revert. Committed: https://code.google.com/p/dart/source/detail?r=35247

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M tests/lib/lib.status View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ricow1
6 years, 8 months ago (2014-04-22 06:48:55 UTC) #1
ricow1
I will update issue 15566 with a comment
6 years, 8 months ago (2014-04-22 06:50:08 UTC) #2
ricow1
tbr
6 years, 8 months ago (2014-04-22 06:59:59 UTC) #3
ricow1
Committed patchset #1 manually as r35247 (presubmit successful).
6 years, 8 months ago (2014-04-22 07:01:11 UTC) #4
floitsch
LGTM.
6 years, 8 months ago (2014-04-22 08:50:58 UTC) #5
rmacnak
6 years, 8 months ago (2014-04-22 16:51:22 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698