Issue 246173002: Revert "Mark private functions in dart:* that are native or constructors as not visible (omitted fr…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 246173002: Revert "Mark private functions in dart:* that are native or constructors as not visible (omitted fr… (Closed)

Created:
6 years, 8 months ago by rmacnak

Modified:
6 years, 8 months ago

Reviewers:

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Mark private functions in dart:* that are native or constructors as not visible (omitted from stack traces and ineligible for reflective enumeration or invocation)." Committed: https://code.google.com/p/dart/source/detail?r=35238

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+81 lines, -259 lines)			Patch
M	runtime/lib/mirrors.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/object.h	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	runtime/vm/object.cc	View	2 chunks	+38 lines, -3 lines	0 comments	Download
M	runtime/vm/object_test.cc	View	1 chunk	+10 lines, -9 lines	0 comments	Download
M	runtime/vm/parser.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/parser.cc	View	4 chunks	+0 lines, -18 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/lib/lib.status	View	2 chunks	+3 lines, -2 lines	0 comments	Download
D	tests/lib/mirrors/invocation_fuzz_test.dart	View	1 chunk	+0 lines, -162 lines	0 comments	Download
A +	tests/lib/mirrors/invoke_natives_fuzz_test.dart	View	6 chunks	+28 lines, -55 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

rmacnak

6 years, 8 months ago (2014-04-22 00:09:01 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r35238 (presubmit successful).

Expand Messages | Collapse Messages