Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 246133003: VM mirrors: Use UnmodifiableMapView from dart:collection (Closed)

Created:
6 years, 8 months ago by kevmoo
Modified:
6 years, 8 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

VM mirrors: Use UnmodifiableMapView from dart:collection R=rmacnak@google.com Committed: https://code.google.com/p/dart/source/detail?r=35274

Patch Set 1 #

Patch Set 2 : less tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -33 lines) Patch
M runtime/lib/mirrors_impl.dart View 1 6 chunks +7 lines, -33 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kevmoo
6 years, 8 months ago (2014-04-22 03:26:01 UTC) #1
rmacnak
LGTM
6 years, 8 months ago (2014-04-22 16:56:23 UTC) #2
kevmoo
6 years, 8 months ago (2014-04-22 18:39:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r35274 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698