Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 24612002: Don't compile io_service if io is not supported. (Closed)

Created:
7 years, 2 months ago by Anders Johnsen
Modified:
7 years, 2 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Don't compile io_service if io is not supported. BUG= R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=27890

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M runtime/bin/io_impl_sources.gypi View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
A + runtime/bin/io_service_unsupported.cc View 1 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Anders Johnsen
7 years, 2 months ago (2013-09-25 16:13:24 UTC) #1
Bill Hesse
https://codereview.chromium.org/24612002/diff/2/runtime/bin/io_impl_sources.gypi File runtime/bin/io_impl_sources.gypi (right): https://codereview.chromium.org/24612002/diff/2/runtime/bin/io_impl_sources.gypi#newcode63 runtime/bin/io_impl_sources.gypi:63: 'secure_socket_unsupported.cc', Add io_service_unsupported.cc here. But the problem may be ...
7 years, 2 months ago (2013-09-25 16:25:54 UTC) #2
Anders Johnsen
Sync IO calls are still available. https://codereview.chromium.org/24612002/diff/2/runtime/bin/io_impl_sources.gypi File runtime/bin/io_impl_sources.gypi (right): https://codereview.chromium.org/24612002/diff/2/runtime/bin/io_impl_sources.gypi#newcode63 runtime/bin/io_impl_sources.gypi:63: 'secure_socket_unsupported.cc', On 2013/09/25 ...
7 years, 2 months ago (2013-09-25 16:29:02 UTC) #3
Bill Hesse
lgtm
7 years, 2 months ago (2013-09-25 16:29:35 UTC) #4
Anders Johnsen
7 years, 2 months ago (2013-09-25 16:31:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r27890 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698