Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issue 246013007: Trigger analysis when context.applyChanges request is received. (Closed)

Created:
6 years, 8 months ago by Paul Berry
Modified:
6 years, 8 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Trigger analysis when context.applyChanges request is received. With this change, the analysis server is now capable of analyzing a source file and responding with error notifications. R=jwren@google.com Committed: https://code.google.com/p/dart/source/detail?r=35373

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/domain_context.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/domain_context_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Paul Berry
6 years, 8 months ago (2014-04-23 20:58:07 UTC) #1
jwren
On 2014/04/23 20:58:07, Paul Berry wrote: LGTM
6 years, 8 months ago (2014-04-23 21:13:36 UTC) #2
Paul Berry
Committed patchset #1 manually as r35373 (presubmit successful).
6 years, 8 months ago (2014-04-24 14:58:19 UTC) #3
Brian Wilkerson
6 years, 8 months ago (2014-04-24 16:17:21 UTC) #4
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698