Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 24598002: dart:io | Change two secure networking tests to account for the session cache. (Closed)

Created:
7 years, 2 months ago by Bill Hesse
Modified:
7 years, 2 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

dart:io | Change two secure networking tests to account for the session cache. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=27886

Patch Set 1 #

Total comments: 1

Patch Set 2 : Comment change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -11 lines) Patch
M tests/standalone/io/https_bad_certificate_client.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/secure_multiple_client_server_test.dart View 2 chunks +3 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Bill Hesse
The changes to secure_multiple_client_server_test, to test the session cache, made in r27875, were not needed, ...
7 years, 2 months ago (2013-09-25 15:26:35 UTC) #1
Bill Hesse
The changes to secure_multiple_client_server_test, to test the session cache, made in r27875, were not needed, ...
7 years, 2 months ago (2013-09-25 15:27:04 UTC) #2
Søren Gjesse
lgtm
7 years, 2 months ago (2013-09-25 15:30:23 UTC) #3
Bill Hesse
7 years, 2 months ago (2013-09-25 15:32:28 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r27886 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698