Issue 24596003: Clean up IOService implementation to be shared between patched and non-patched code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24596003: Clean up IOService implementation to be shared between patched and non-patched code. (Closed)

Created:
7 years, 2 months ago by Anders Johnsen

Modified:
7 years, 2 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Clean up IOService implementation to be shared between patched and non-patched code. BUG= Committed: https://code.google.com/p/dart/source/detail?r=27888

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+96 lines, -79 lines)			Patch
M	runtime/bin/io_service_patch.dart	View	2 chunks	+2 lines, -41 lines	0 comments	Download
M	runtime/bin/socket_patch.dart	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/lib/io_patch.dart	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	sdk/lib/io/directory_impl.dart	View	8 chunks	+8 lines, -8 lines	0 comments	Download
M	sdk/lib/io/file_impl.dart	View	18 chunks	+18 lines, -18 lines	0 comments	Download
M	sdk/lib/io/file_system_entity.dart	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	sdk/lib/io/io.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	sdk/lib/io/io_service.dart	View	1 chunk	+48 lines, -0 lines	0 comments	Download
M	sdk/lib/io/iolib_sources.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/io/link.dart	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	sdk/lib/io/secure_socket.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Anders Johnsen

Committed patchset #1 manually as r27888 (presubmit successful).

7 years, 2 months ago (2013-09-25 15:54:12 UTC) #2

Message was sent while issue was closed.

lgtm