Get rid of several old collection workarounds in serialization

Get rid of several old collection workarounds in serialization

R=jmesserly@google.com, kevmoo@j832.com

Committed: https://code.google.com/p/dart/source/detail?r=28315

[Alan Knight, 2013-09-25 19:26:57]

Uses Map.identity(), but also once I got looking at the code was able to delete
quite a lot of other stuff that there are now at least acceptable workarounds
for. It'd be nicer if I could do things like send asMap to a Map or an Iterable
and not have to type test for it, but it's much nicer than when I wrote those
things originally.

[kevmoo-old, 2013-09-25 20:30:03]

DBR

https://codereview.chromium.org/24582004/diff/1/pkg/serialization/lib/src/ser...
File pkg/serialization/lib/src/serialization_helpers.dart (right):

https://codereview.chromium.org/24582004/diff/1/pkg/serialization/lib/src/ser...
pkg/serialization/lib/src/serialization_helpers.dart:64: values(x) {
return type of Iterable, then?

[Alan Knight, 2013-09-26 16:39:07]

https://codereview.chromium.org/24582004/diff/1/pkg/serialization/lib/src/ser...
File pkg/serialization/lib/src/serialization_helpers.dart (right):

https://codereview.chromium.org/24582004/diff/1/pkg/serialization/lib/src/ser...
pkg/serialization/lib/src/serialization_helpers.dart:64: values(x) {
On 2013/09/25 20:30:03, kevmoo wrote:
> return type of Iterable, then?

Yes, I suppose so.

[kevmoo-old, 2013-10-04 14:47:45]

On 2013/09/26 16:39:07, Alan Knight wrote:
>
https://codereview.chromium.org/24582004/diff/1/pkg/serialization/lib/src/ser...
> File pkg/serialization/lib/src/serialization_helpers.dart (right):
> 
>
https://codereview.chromium.org/24582004/diff/1/pkg/serialization/lib/src/ser...
> pkg/serialization/lib/src/serialization_helpers.dart:64: values(x) {
> On 2013/09/25 20:30:03, kevmoo wrote:
> > return type of Iterable, then?
> 
> Yes, I suppose so.

LGTM

[Jennifer Messerly, 2013-10-04 22:40:04]

lgtm

https://codereview.chromium.org/24582004/diff/6001/pkg/serialization/lib/src/...
File pkg/serialization/lib/src/reader_writer.dart (right):

https://codereview.chromium.org/24582004/diff/6001/pkg/serialization/lib/src/...
pkg/serialization/lib/src/reader_writer.dart:43: new Map<Object,
Reference>.identity();
This should stay as HashMap right? LinkedHashMap will cost performance in
exchange for being more deterministic. Normally the perf cost doesn't matter,
but serialization is one of the places where it might.

https://codereview.chromium.org/24582004/diff/6001/pkg/serialization/lib/src/...
File pkg/serialization/lib/src/serialization_helpers.dart (right):

https://codereview.chromium.org/24582004/diff/6001/pkg/serialization/lib/src/...
pkg/serialization/lib/src/serialization_helpers.dart:52: throw new
ArgumentError("Invalid argument");
nit (from original code): this message doesn't give much info :)

same below.

[Alan Knight, 2013-10-07 17:14:36]

https://codereview.chromium.org/24582004/diff/6001/pkg/serialization/lib/src/...
File pkg/serialization/lib/src/reader_writer.dart (right):

https://codereview.chromium.org/24582004/diff/6001/pkg/serialization/lib/src/...
pkg/serialization/lib/src/reader_writer.dart:43: new Map<Object,
Reference>.identity();
On 2013/10/04 22:40:04, John Messerly wrote:
> This should stay as HashMap right? LinkedHashMap will cost performance in
> exchange for being more deterministic. Normally the perf cost doesn't matter,
> but serialization is one of the places where it might.

Done.

https://codereview.chromium.org/24582004/diff/6001/pkg/serialization/lib/src/...
File pkg/serialization/lib/src/serialization_helpers.dart (right):

https://codereview.chromium.org/24582004/diff/6001/pkg/serialization/lib/src/...
pkg/serialization/lib/src/serialization_helpers.dart:52: throw new
ArgumentError("Invalid argument");
On 2013/10/04 22:40:04, John Messerly wrote:
> nit (from original code): this message doesn't give much info :)
> 
> same below.

Done.

[Alan Knight, 2013-10-07 17:16:28]

Committed patchset #3 manually as r28315 (presubmit successful).