Issue 24567003: Bug fix and cleanup of inlining of recognized [] methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24567003: Bug fix and cleanup of inlining of recognized [] methods. (Closed)

Created:
7 years, 2 months ago by Florian Schneider

Modified:
7 years, 2 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Bug fix and cleanup of inlining of recognized [] methods. 1. Fix a bug with polymorphic inlining of [] on platforms that don't support inlined SIMD ops (e.g. MIPS), or unboxed int32/uint32. (ia32 with SSE <4.1). 2. Cleanup of duplicate code. R=kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=28000

Patch Set 1 #

Total comments: 1

Patch Set 2 : removed invalid ASSERT #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -42 lines)			Patch
M	runtime/vm/flow_graph_optimizer.cc	View	1	3 chunks	+18 lines, -38 lines	0 comments	Download
M	runtime/vm/object.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	tests/standalone/float_array_test.dart	View		2 chunks	+15 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

https://codereview.chromium.org/24567003/diff/1/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/24567003/diff/1/runtime/vm/flow_graph_optimizer.cc#newcode1072 runtime/vm/flow_graph_optimizer.cc:1072: if (!ShouldInlineSimd()) return false; This check was not performed ...

7 years, 2 months ago (2013-09-25 12:10:07 UTC) #2

Florian Schneider

7 years, 2 months ago (2013-09-27 10:27:53 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r28000 (presubmit successful).

Expand Messages | Collapse Messages