Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 24558002: VM: Fix CHA for Object. (Closed)

Created:
7 years, 2 months ago by Florian Schneider
Modified:
7 years, 2 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org, srdjan
Visibility:
Public.

Description

VM: Fix CHA for Object. Class hierarchy analysis does not track subclasses of Object. Therefore, it needs to safely assume that any functions has an override. This fixes test failures when running with --optimization-counter-threshold=5. R=kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=27874

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M runtime/vm/cha.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Florian Schneider
@Regis: Why don't we track subclasses of Object with CHA? I did not find any ...
7 years, 2 months ago (2013-09-25 10:52:28 UTC) #1
Kevin Millikin (Google)
LGTM, but why don't we just track them?
7 years, 2 months ago (2013-09-25 10:57:02 UTC) #2
Florian Schneider
Committed patchset #1 manually as r27874 (presubmit successful).
7 years, 2 months ago (2013-09-25 11:04:59 UTC) #3
regis
7 years, 2 months ago (2013-09-25 23:02:49 UTC) #4
Message was sent while issue was closed.
LGTM

Thanks for fixing the bug.

We decided not to keep track of the subclasses of Object for efficiency reasons,
because every class extends Object.

The drawback is that we have to assume that any function in Object is overridden
(your fix).

I checked with Srdjan and he thinks that most functions of Object are indeed
overridden by some class, mostly from the core lib. So we should not be
penalized too much by this assumption.

Powered by Google App Engine
This is Rietveld 408576698